Fix temporary "users" input on add existing users
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
KARL3 |
Fix Released
|
Medium
|
Balazs Ree |
Bug Description
In community membership, the Add Existing User needs a variation on the tagbox. The former is described in the text below.
If we run out of time, we can stick to the KARL2 behavior.
Paul wrote:
"""
I have another potential use of the tagbox-style
autocomplete. I'd like to get an estimate for its use, and see if it
is worthwhile investigating it.
In KARL2, when you create a new community, you are sent to a screen to
add existing KARL users to that community. You can send them an email
message that lets them know they were added.
IIRC, you add existing users one-by-one. Meaning, you get the
autocomplete, but only to choose one user. You then type a message.
That kind of sucks, because you have to repeat the process over and
over. Wouldn't it be nice if we had something like the tagbox, where
you can lookup a person using autocomplete, press enter, lookup
another person, repeat (and remove someone if you changed your mind),
then send a single email message?
There might be some sharp edges on this. Foremost, validation. If we
want to allow the form to fail in any way and return whatever they
typed, we might have a use case that the tagbox doesn't cover. We
could choose to cover this by doing validation during onchange
(meaning, pressing enter or clicking "Add User"). Meaning, we send a
message to the server, it says no, we present an error message
preventing that "caplet" from being created.
Also, it isn't like the normal tagbox case, where we update as we
type. It's more like the tag-on-adding use case.
We would have to parameterize more of the tagbox, e.g. the text for
the button.
Anyway, I want to be careful about going beyond the basics of "Port
KARL2". We don't *HAVE* to improve the user experience on that screen.
Note that, if we *DO* think it is realistic, I'll ask similar
questions for the "Invite New User" screen. :^)
"""
And Balazs replied:
"""
Validation does work on the Add Blog page. So we can do the same, plus
we can add constraints to the taglist value as well.
If we follow this approach we would also use the tagbox in form-mode in
these use cases, which means we don't need any ajax to happen, just let
the values submitted and get the server do the right thing.
If, the form validation fails, then the user gets back the previously
entered values, this also works on Add Blog.
Which means yes extra work, but we may be able to choose a way to do it
similarly in each of these usecases.
Maybe, even if we decide we want this we can keep it as low priority,
and only spend time on it when we see that we are good with the
schedule.
"""
Changed in karl3: | |
assignee: | nobody → ree |
importance: | Undecided → Medium |
milestone: | none → m2 |
Changed in karl3: | |
status: | New → In Progress |
Changed in karl3: | |
status: | In Progress → Fix Committed |
Changed in karl3: | |
status: | Fix Committed → Fix Released |
I don't see the autocomplete stuff working, although when I hit "add" I do get a box. But submitting the form results in the server rejecting it due to a validation error for the users box; I think the field names are wrong in the POST data.