Relative products path not compatible with Five

[Malthe Borch]

In a deployment where zope.conf is not autogenerated, it's often convenient to express paths relative to the main deployment directory. However, the logic in Five that loads configuration files (ZCML) incorrectly handles products with a relative module path (__file__).

Attached is a patch that fixes the situation in Products.Five; it may not be the correct place to patch.

[Tres Seaver (tseaver)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Malthe wrote:
> Public bug reported:
>
> In a deployment where zope.conf is not autogenerated, it's often
> convenient to express paths relative to the main deployment directory.
> However, the logic in Five that loads configuration files (ZCML)
> incorrectly handles products with a relative module path (__file__).
>
> Attached is a patch that fixes the situation in Products.Five; it may
> not be the correct place to patch.

Maybe the better place in in the 'App.Products' bits which calls the
product's 'initialize' at startup (OFS.Applciation.install_product).
A test would be nice, too. ;)

Tres.
- --
===================================================================
Tres Seaver [phone] <email address hidden>
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJjDhz+gerLs4ltQ4RAuyvAJ9O8gji8xc9mmZ5rqt5RhU3n56+KQCgvlx+
7i+TjbyQT+vU9at4SYgz5DE=
=lEIP
-----END PGP SIGNATURE-----

[Malthe Borch (mborch)]

Excellent, I'll get a patch uploaded here for review on Monday, along with a test.

[Malthe Borch (mborch)]

Seems to correct place to patch is in the ``import_product`` method, since not all products get installed.

[Malthe Borch (mborch)]

I can't seem to run the OFS tests on my system, but here's an updated patch (without any test, because I can't run it).

[Tres Seaver (tseaver)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Malthe wrote:
> I can't seem to run the OFS tests on my system, but here's an updated
> patch (without any test, because I can't run it).
>
>
>
> ** Attachment added: "Updated patch for the OFS module"
> http://launchpadlibrarian.net/22433299/patch.diff

OK, a little more digging: I think the correct place to fix the
underlying problem (relative paths on Products.__path__) is inside the
ZConfig handler. 'root_handler()', located in
src/Zope2/Startup/handlers.py. If we absolutize the paths which come
from the config file at startup time, then we don't have to whack-a-mole
the places in App.Products / OFS.Application which might import products.

Tres.
- --
===================================================================
Tres Seaver [phone] <email address hidden>
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJkXO5+gerLs4ltQ4RAob8AKCt+pOnBDPp/pIvA+qnwjt84XJ+TgCeJQ54
7x+TxqN2VGKPtAWnfbn1ylg=
=Jmdi
-----END PGP SIGNATURE-----

[Tres Seaver (tseaver)]

Can you please verify that the attached patch fixes the issue for you?

The patch is against the 2.12 branch, but should also apply cleanly to the trunk.