invirt-reload fails on xvm-dev

[Anders Kaseorg]

root@xvm-dev:~# invirt-reload
 * Reloading config for invirt-database-server [ OK ]
 * Reloading PostgreSQL 8.3 database server [ OK ]
 * Restarting the Invirt DNS server invirt-dns [ OK ]
 * Reloading Invirt VNC client certificates invirt-vnc-client Certificate was added to keystore
Invalid hostname specified
keytool error: java.lang.Exception: Input not an X.509 certificate
                                                                         [ OK ]
 * Reloading config for invirt-web Traceback (most recent call last):
  File "/usr/bin/mako-render", line 38, in <module>
    main()
  File "/usr/bin/mako-render", line 35, in main
    print render(data)
  File "/usr/bin/mako-render", line 8, in render
    return Template(data, lookup=lookup).render()
  File "/usr/lib/python2.5/site-packages/mako/template.py", line 121, in render
    return runtime._render(self, self.callable_, args, data)
  File "/usr/lib/python2.5/site-packages/mako/runtime.py", line 335, in _render
    _render_context(template, callable_, context, *args, **_kwargs_for_callable(callable_, data))
  File "/usr/lib/python2.5/site-packages/mako/runtime.py", line 352, in _render_context
    _exec_template(inherit, lclcontext, args=args, kwargs=kwargs)
  File "/usr/lib/python2.5/site-packages/mako/runtime.py", line 385, in _exec_template
    callable_(context, *args, **kwargs)
  File "memory:0x7f97da012510", line 24, in render_body
  File "/var/lib/python-support/python2.5/invirt/common.py", line 22, in __getattr__
    % (prefix, key))
invirt.common.InvirtConfigError: missing configuration variable svn
                                                                         [fail]
 * Stopping web server apache2 [ OK ]
Stopping kstart for Apache2: k5start.
Starting kstart for Apache2: k5startNote: Operation is performed on cell sipb.mit.edu
.
 * Starting web server apache2 [ OK ]
 * Reloading Invirt web server iptables rules invirt-web-iptables [ OK ]

[Greg Price (gregprice)]

On Fri, Feb 06, 2009 at 10:09:51AM -0000, Anders Kaseorg wrote:
> * Reloading config for invirt-web Traceback (most recent call last):
> File "/usr/bin/mako-render", line 38, in <module>
> [...]
> invirt.common.InvirtConfigError: missing configuration variable svn
> [fail]

This is known and harmless, though we should fix it to stop throwing
an error. There's no svn stanza in xvm-devconfig, because it doesn't
serve a SVN repo, and there shouldn't particularly be. The
consequence of the error is that sites-available/svn is empty, which
has exactly the right effect.

The ultimate right thing here is that we should have a way of
inserting random stuff into the Apache config other than by putting it
in Mako in invirt-web and giving some pieces of it names in the
config. For the svn case this is fairly straightforward; let
/etc/invirt/apache/sites.d/ or something be copied into
sites-available.

The other random hack we have in our web config is the Trac redirect;
supporting that would be a bit more complex. But since we don't use
Trac -- here we are -- we should just cut it.

Greg

[Evan Broder (broder)]

Greg Price wrote:
> For the svn case this is fairly straightforward; let
> /etc/invirt/apache/sites.d/ or something be copied into
> sites-available.
>

Nah - it's easier than that. Just finish the git conversion and we don't
have to worry about it anymore :-P

- Evan

[Mitchell Berger (mitchb)]

> Nah - it's easier than that. Just finish the git conversion and we don't
> have to worry about it anymore :-P

Funny, that. It happened. And indeed:

root@xvm-dev:~# invirt-reload
 * Reloading config for invirt-database-server [ OK ]
invoke-rc.d: unknown initscript, /etc/init.d/postgresql-8.3 not found.
invoke-rc.d: initscript invirt-database-server, action "force-reload" failed.
 * Restarting the Invirt DNS server invirt-dns [ OK ]
 * Reloading Invirt iptables rules invirt-iptables [ OK ]
 * Reloading Invirt VNC client certificates invirt-vnc-client Certificate was added to keystore
Certificate was added to keystore
Certificate was added to keystore
Certificate was added to keystore
                                                                                                [ OK ]
 * Reloading config for invirt-web [ OK ]
 * Stopping web server apache2 [ OK ]
Stopping kstart for Apache2: k5start.
Starting kstart for Apache2: k5startNote: Operation is performed on cell sipb.mit.edu
.
 * Starting web server apache2 [ OK ]
root@xvm-dev:~#