No validation of discovered cookie - leading to requestsync erroneously assuming that I am in core-dev

[Max Bowsher]

Binary package hint: ubuntu-dev-tools

I just experienced requestsync falsely believing I'm a core-dev.

It turned out to be that it was picking up a dead launchpad logincookie from an old firefox user profile instead of my active firefox profile.

This was compounded by there being no checking whether the discovered cookie is still valid, and further compounded by ubuntutools.lp.isLPTeamMember silently returning True if the cookie it is using is invalid.

1) ubuntu-dev-tools needs to be intelligent about using the *right* firefox profile when there is more than one.

2) When a launchpad cookie is discovered, it must not blindly assumed to be valid

3) isLPTeamMember needs to understand the difference between a page asking you to login, and a page telling you you are a member of a team

[ And 4) isLPTeamMember refers to the sys and urllib2 modules in the error handling code, but doesn't import them, so if an error occurs, it dies messily ]

[Anders Kaseorg (andersk)]

This patch rewrites isLPTeamMember to use launchpadlib instead.

[Anders Kaseorg (andersk)]

Apparently a similar patch was already included in bzr (r394), so ignore that.

[Andrew Mitchell (ajmitch)]

I'll mark it as won't fix & have removed the sponsors team then, since it looks to already be in 0.74