class TestLocationConfig defined twice in tests/test_config.py

[Erik Bågfors]

The class TestLocationConfig is defined twice in test/test_config.py

: [bagfors@zyrgelkwyt]$ ; grep TestLocationConfig test_config.py

class TestLocationConfig(TestCase):
class TestLocationConfig(TestCaseInTempDir):

jblack said I should report it and also said that I should say

"jblack said that you can't lart me for this because he's the one that needs the larting"

:)

/Erik

[Wouter van Heyst (larstiq)]

On Thu, Feb 23, 2006 at 10:03:44AM -0000, Erik Bågfors wrote:
> Public bug reported:
> https://launchpad.net/malone/bugs/32587
>
> Affects: bzr (upstream)
> Severity: Normal
> Priority: (none set)
> Status: Unconfirmed
>
> Description:
> The class TestLocationConfig is defined twice in test/test_config.py
>
> : [bagfors@zyrgelkwyt]$ ; grep TestLocationConfig test_config.py
> class TestLocationConfig(TestCase):
> class TestLocationConfig(TestCaseInTempDir):

Only the latter one actually gets tested in a bzr selftest run. It looks
like this got merged in <email address hidden>
Not sure what went wrong there :/

Wouter van Heyst

[Michael Ellerman (michael-ellerman)]

Confirmed in bzr mainline 1558.

[Michael Ellerman (michael-ellerman)]

Fix committed as revno 1534 at:

http://michael.ellerman.id.au/files/bzr/mpe

[Michael Ellerman (michael-ellerman)]

Erm .. this patch seems to have gone in, according to the revision history. But there's _still_ two definitions of TestLocationConfig in tests/test_config.py. WTH?

concordia ~/src/bzr/repo/trunk$ bzr annotate --long bzrlib/tests/test_config.py|grep TestLocationConfig
merge <email address hidden> 20051017 | class TestLocationConfig(TestCase):
merge <email address hidden> 20060317 | class TestLocationConfig(TestCaseInTempDir):

[Martin Pool (mbp)]

Fix committed (again) in my branch; also updated some tests that had drifted out of sync.