Crash when going back from a menu repeatedly

[Florian Boucault]

Steps to reproduce:
1. Go to Music > Albums
2. Go into an album
3. Come back from it
4. Execute step 2. and 3. repeatedly (not necessarily rapidly)

Current result:
Elisa crashes with lots of error messages on the console related to refcounts and invalid pointer cast.

Expected result:
No crash.

[Florian Boucault (fboucault)]

This happens on all combination of OS/hardware and fairly often. There is a bug in Pigment and Elisa triggers it.

Elisa's revision 1030 (upicek branch) introduced it. Before that, no crash at all. It is part of Elisa 0.5.24 and 0.5.25.

[Florian Boucault (fboucault)]

Loïc is working on the Pigment side. I am isolating the conditions that trigger it on Elisa's side.

[Florian Boucault (fboucault)]

Sorry, I meant revision 1031 of upicek, not 1030.

[Florian Boucault (fboucault)]

That's a patch that seems to fix it. It needs extensive test and to make sure it does not re-introduce the bug revision 1031 was trying to solve.

[Florian Boucault (fboucault)]

Please ignore aforementioned patch. A slightly improved version was sent as part of a merge request:

https://elisa.fluendo.com/quality/review/request/%<email address hidden>%3E