Mixxx

Stack smash on OS X in AnalyserBPM

Bug #325437 reported by Nick
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Undecided
RJ Skerry-Ryan
1.7
Fix Released
Undecided
RJ Skerry-Ryan
Mixxx 1.7.0

Bug Description

AnalyserBPM::process has a hardcoded buffer for samples to pass into soundtouch. The size of this buffer was increased to make BPM detection better, but this has started causing crashes on OS X (because it is overflowing the stack).

I moved the buffer into the class instead of the method and that seemed to fix it but I've found files that it will crash on after starting to play the track for a few seconds.

Posting this so we record test cases to make sure we don't break this again in the future.

Revision history for this message
Nick (kousu) wrote :
Revision history for this message
Nick (kousu) wrote :
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

We need to remember to check this again once we merge in the fix for the SoundTouch buffer overflow.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Self assign, and confirm since I believe I can reproduce it.

Changed in mixxx:
assignee: nobody → rryan
status: New → Confirmed
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

We don't use this buffer anymore, and furthermore the files do not crash anymore for me. Marking fixed in 1.7.0.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5091

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.