FSImages send out unnecessary cache purges upon first access

Bug #325246 reported by newbery
2
Affects Status Importance Assigned to Milestone
Zope CMF buildout
Fix Released
Medium
Unassigned

Bug Description

Upon startup, with the CMFSquidTool installed and configured to send purge requests, FSImages appear to generate a bunch of unnecessary purges. The cause appears to be due to ZCacheable_invalidate() being called unconditionally, without checking to see if the filesystem moddate has changed.

Perhaps someone can do a sanity check on the patches I've attached?

Revision history for this message
newbery (ric-digitalmarbles) wrote :
Revision history for this message
Tres Seaver (tseaver) wrote : Re: [Bug 325246] Re: FSImages send out unnecessary cache purges upon first access

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

newbery wrote:
> ** Attachment added: "FSObject-FSImage.patch"
> http://launchpadlibrarian.net/21975749/FSObject-FSImage.patch

The patch looks fine to me, although I think I would want unit tests
which verified the new behavior.

Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 <email address hidden>
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJifyO+gerLs4ltQ4RAsugAKCLCajgDbDzj32nSPVTdrF2F5f/AwCgx+f9
CtW1XhLx2O5c5jsvVELGypI=
=a1Fk
-----END PGP SIGNATURE-----

Revision history for this message
Jens Vagelpohl (dataflake-deactivatedaccount-deactivatedaccount) wrote :

Thanks for the patch. I added some tests and added it to the SVN trunk for includion in CMF 2.2.0:

http://svn.zope.org/?rev=99882&view=rev

Changed in zope-cmf:
assignee: nobody → Jens Vagelpohl (jens-dataflake)
importance: Undecided → Medium
milestone: none → 2.2.0
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.