Handle invalid characters when tagging

Bug #324438 reported by Paul Everitt
2
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Low
Balazs Ree

Bug Description

Presumably there are some invalid characters that can be typed in when doing a tag. Namely, anything that must be escaped for display in a URL. We follow whatever rules KARL2 has for this, so we might need to do some research. For example, does KARL2 allow unicode chars in a tag?

We need to detect in some ways when a tag has a bad char. Perhaps the safest thing to do is let the server decide. This means our protocol needs to support sending back a server-generated error message which we can then display.

Of course, we then have to decide our strategy for displaying errors. jQuery UI dialog, or just a status line somewhere?

Tags: tagbox
Changed in karl3:
assignee: nobody → ree
importance: Undecided → Low
Changed in karl3:
milestone: none → m1
Revision history for this message
Balazs Ree (ree) wrote :

Unicode tags are working now. I agree that such checks should be done in the server.

Error handling for add/del tag should be a task on its own where this has to be covered as well.

Changed in karl3:
status: New → In Progress
Revision history for this message
Balazs Ree (ree) wrote :

Invalid characters are now both checked on client and on server.

What is the list of allowed characters? Currently I allow a-zA-Z0-9.

There is no automatic conversion attempted, bad characters will yield an error.

Revision history for this message
Balazs Ree (ree) wrote :

a-zA-Z0-9\-\._ are allowed now.

Changed in karl3:
status: In Progress → Fix Committed
Changed in karl3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.