Fading text assumes light text on dark background

[Stephan Sokolow]

I use a variation of the "Grey" theme which I call "Soft_letterpaper" (Actually, "Soft LetterPaper", but that's another bug) and the fading text is distractingly broken because your algorithm assumes light text on a dark background. (It works perfectly well with the default "Green" theme and anything else similar)

When the fade begins, it jumps to faint, then fades to visible, then abruptly vanishes. (You can test it yourself by selecting the Grey theme and then watching the "Style changed to Grey" message)

[Florian Heinle (tiax)]

Hi,

thanks for your report.

I guess making the colors theme-dependant might be the best idea.

There's a blocker before we can fix this but eventually we will :)

[Florian Heinle (tiax)]

Two points here:

1. I'm bad at math in base10 to begin with, but hex - even worse. I don't know how to calculate proper color fading in hex or any other way.

2. I don't think the current situation looks too bad, actually I find it aesthetically pleasing enough.

Maybe we should just keep it the way it is?

[Stephan Sokolow (ssokolow)]

Unfortunately, I find the current state of things distracting enough that I'm more willing to fork PyRoom (or possibly re-implement it in PyQt if it would be more fun) than to tolerate it.

I'm pretty good at math, so I'll try whipping up a patch to fix it as soon as I've caught up to some real-life obligations I fell behind on.

[Florian Heinle (tiax)]

Hi,

a patch would definitely be the best solution, yes. Of course we'd be more than willing to integrate it :)

[Adam Rooke (abelianr)]

I think this should be fixed in trunk now. Fading now works correctly on all themes within pyroom for me, but please test away

[Florian Heinle (tiax)]

fixed in 0.4 release