Build machine details, mode, and trustedness should be edited on the same page

Bug #32247 reported by Matthew Paul Thomas
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Michael Nelson

Bug Description

The page for changing a build machine's mode (+mode), the page for changing all the machine's other details if you aren't an admin (+edit), and the page for changing all the machine's details if you are an admin (+admin), should all be the same page. Things you don't have permission to change should be shown but unclickable.

Tags: lp-soyuz ui
Revision history for this message
Celso Providelo (cprov) wrote :

I'm not against, but I'm not sure about the form format.
Long forms with text box tends to induce errors. Maybe we can cover description and failnotes fields with the fieldset tag. What do you think ?

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Implementation of the FormLayout spec will make the form much shorter. Even now, the <textareas> are too long and many of the captions are unnecessary.

description: updated
Dafydd Harries (daf)
Changed in launchpad-buildd:
status: Unconfirmed → Confirmed
Changed in launchpad-buildd:
assignee: nobody → malcolmcleaton
Changed in soyuz:
assignee: malcolmcleaton → nobody
Changed in soyuz:
milestone: none → 2.2.8
Revision history for this message
Michael Nelson (michael.nelson) wrote :

During a chat with Julian and Celso, we decided to merge +admin and +edit, but put form for editing the mode directly on the builder-index page (it will post to the normal url and redirect back to the builder-index, obviously only being visible/functional to those with the correct permission).

Also, we can't even see any reason for the edit/admin distinction.

Changed in soyuz:
assignee: nobody → Michael Nelson (michael.nelson)
status: Triaged → In Progress
Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r9095.

Changed in soyuz:
status: In Progress → Fix Committed
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.