not yet addressed MIR comments

[Alexander Sack]

Binary package hint: jflex

We promoted jflex to main to unblock cut from dependency wait state.

However, mir team had some comments that should be addressed (https://bugs.edge.launchpad.net/ubuntu/+source/jflex/+bug/315403/comments/1) to finalize the MIR promotion:

Current Ubuntu-specific source doesn't change Maintainer to Ubuntu; I think we can solve this by syncing 1.4.2-1 from unstable; doko, can you confirm all changes are in? It seems to from only looking at the changelog.

dpkg-parsechangelog should be preferred to retrieve the upstream version from changelog.

debian/copyright should mention the exact version of the license as there's no particular grant on moving to newer versions. I found the license to be a reformated GPL-2 with some reformatting changes.
  A random source file doesn't list a particular version in the grant either, for instance src/JFlex/gui/GridPanelConstraint.java:
 * JFlex 1.4.2 *
 * Copyright (C) 1998-2008 Gerwin Klein <email address hidden> *
 * All rights reserved. *
 * *
 * This program is free software; you can redistribute it and/or modify *
 * it under the terms of the GNU General Public License. See the file *
 * COPYRIGHT for more information. *
 * *
 * This program is distributed in the hope that it will be useful, *
 * but WITHOUT ANY WARRANTY; without even the implied warranty of *
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
 * GNU General Public License for more details. *
 * *
 * You should have received a copy of the GNU General Public License along *
 * with this program; if not, write to the Free Software Foundation, Inc., *
 * 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA *

There's one exception: examples/binary/StraightStreamReader.java is version 2 or later.

Stephen Ostermiller doesn't appear in the copyright holders.

Copyright needs to be updated to 2008.

(I also wonder whether you should have default-jdk in Build-Depends since ant is used in clean as much as during build, but I don't think this matters too much in practice since you only have an arch: all package, so build-deps-indep are always installed.)

[Alexander Sack (asac)]

blocking jaunty beta to keep this on radar and get the MIR comments addressed for final release.

[Steve Langasek (vorlon)]

BTW, we also have both jflex and jlex in main now; it would be good if someone could look into replacing jlex with jflex completely to eliminate the redundancy here.

[Matthias Klose (doko)]

updated the copyright in the debian packaging repository.

[Alexander Sack (asac)]

Matthias, did you close this bug in that package or set we set this to
fix committed at least?

On Fri, Jan 30, 2009 at 11:08:16AM -0000, Matthias Klose wrote:
> updated the copyright in the debian packaging repository.
>
>
> ** Changed in: jflex (Ubuntu Jaunty)
> Assignee: Matthias Klose (doko) => (unassigned)
>

 - Alexander

[Martin Pitt (pitti)]

Current jaunty version addresses the b-dep changes, but the debian/copyright isn't fixed yet. It is fixed in

  http://svn.debian.org/wsvn/pkg-java/trunk/jflex/debian/copyright?op=diff&rev=7907&sc=1

Matthias, can you please either upload this to Debian and we just sync it over (preferred, we don't have any other delta any more), or apply to the Jaunty package?

[Matthias Klose (doko)]

now in incoming/unstable, please sync

[Martin Pitt (pitti)]

Synced; thanks, Matthias!