Cached karma should be recalculated after merging an account

[Christian Reis]

We recently saw in bug 2569 that a merged account was listed with tons of karma. Salgado and I looked into this today and discovered the root cause: when merging the person's karma records are transferred, but the cached karma is not recalculated. This needs to be done at merge time.

[Guilherme Salgado (salgado)]

The fix for this bug was merged into rocketfuel on 2005-10-19, with "Recalculate the karma cache upon merging of accounts and some other fixes. r=BjornT" as the commit message. The patch is found on revision 2716 of our bzr tree. I don't know what happened later, but this fix, together with the tests got reverted somehow.

[Stuart Bishop (stub)]

Guilherme Salgado wrote:
> The fix for this bug was merged into rocketfuel on 2005-10-19, with
> "Recalculate the karma cache upon merging of accounts and some other
> fixes. r=BjornT" as the commit message. The patch is found on revision
> 2716 of our bzr tree. I don't know what happened later, but this fix,
> together with the tests got reverted somehow.

I probably destroyed it when refactoring the karma caches.

This should be minor to fix. Enough people have been shocked by this that it
is worth fixing, even though nothing is actually lost and the karma
corrected during the next daily batch update. It will involve granting the
launchpad database user rights to update the karma cache tables.

--
Stuart Bishop <email address hidden> http://www.canonical.com/
Canonical Ltd. http://www.ubuntu.com/

[Curtis Hovey (sinzui)]

We have decided to delete the karma caches on since they are regenerated, but we are merging the karma total so that the user does not think he has lost karma.

[Anne Gentle (annegentle)]

I also saw this bug this morning while merging two accounts, the Karma: field shows zero. I can wait for it to regenerate in the morning, no problem, but someone suggested that I report it since I observed it. :)

[Curtis Hovey (sinzui)]

It does take about a day. The karma was not lost, it is just not in the UI yet. We will release the fix in a few days so that automatically updates the UI. This fix will also use the oldest membership date.