Merge diff display shold show line numbers

[Eleanor Berger]

The merge diff display for merge proposal should show the line number to the left of each line, to make it easier for people who read it over the web to discuss the change.

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Tom Berger wrote:
> Public bug reported:
>
> The merge diff display for merge proposal should show the line number to
> the left of each line, to make it easier for people who read it over the
> web to discuss the change.

That would make it hard to copy and paste.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEUEARECAAYFAklxBr8ACgkQ0F+nu1YWqI07MQCePNVGfM02Gipp7fRTmL7EzYcC
GXwAlin+vfRfIT1o3ILbhMlgTn/cAO0=
=aHcl
-----END PGP SIGNATURE-----

[Martin Albisetti (beuno)]

On Fri, Jan 16, 2009 at 8:14 PM, Aaron Bentley <email address hidden> wrote:
> That would make it hard to copy and paste.

Unless it where separated as a table like pastebin:
https://pastebin.canonical.com/12390/
:)

--
Martin

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Albisetti wrote:
> On Fri, Jan 16, 2009 at 8:14 PM, Aaron Bentley <email address hidden> wrote:
>> That would make it hard to copy and paste.
>
> Unless it where separated as a table like pastebin:
> https://pastebin.canonical.com/12390/

That approach won't work if we allow lines to wrap.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAklxDEAACgkQ0F+nu1YWqI13PQCdE24TssyYRUBd4ejiIquXxMWZ
pv0AnR5dEo1Vj5XcpdCnZEEIenvzbpsf
=ceVx
-----END PGP SIGNATURE-----

[Martin Albisetti (beuno)]

On Fri, Jan 16, 2009 at 8:37 PM, Aaron Bentley <email address hidden> wrote:
>> Unless it where separated as a table like pastebin:
>> https://pastebin.canonical.com/12390/
>
> That approach won't work if we allow lines to wrap.

Personally, I'd rather not have lines wrap and show line numbers, so
it's a fair trade off.
Bug of course, it's up to you! :)

--
Martin

[Jonathan Lange (jml)]

We need a decision on this one. Marking as incomplete.

[Jonathan Lange (jml)]

We should show line numbers, regardless of pastability, since bug 327135 solves the paste problem -- just like pastebin.

[Tim Penhey (thumper)]

Given most of the coding standards say "short lines" we should be able to have line numbers and no line wrapping.

Can we just give the div an overflow: scroll option if the lines are too long?

[Tim Penhey (thumper)]

Fixed in RF 7753.