grandr not in menu

[Jarno Suni]

Binary package hint: grandr

OS: 8.10
grandr 0.1

Grandr is not added in menu automatically (in Xfce, LXDE, ...)

[Jacob Peddicord (jpeddicord)]

Debdiff attached which should fix this by dropping an OnlyShowIn line, as well as a missing icon from the .desktop itself. Tested on XFCE and GNOME, package is available in my PPA for further testing.

Subscribing u-u-s.

[James Westby (james-w)]

Hi,

What do you think of using "NotShowIn=KDE;" instead? I imagine that was
the point of the line, and it would work in Xfce, LXDE etc.

Also, changing the build system used in a package coming from Debian
should be an exceptional event. If you have problems with the rules file
then I will be happy to help fixing them, and we can then supply patches
for the problem to the Debian maintainer.

On that note has this issue been filed in the Debian BTS?

Thanks,

James

[Jacob Peddicord (jpeddicord)]

James,

I wasn't aware of a NotShowIn line for desktop entries. Changed, thanks.

With regards to the build system, I switched it to CDBS because:
1) it looked like a stock debhelper rules file
2) the source package would fail to build after the first time
Though in retrospect, that probably wasn't the best idea, and this patch leaves debhelper for building. Turns out the build problem I was experiencing was the result of trying to fix a lintian warning: debian-rules-ignores-make-clean-error. If it's okay, I'm just going to let that warning be, because "fixing" it only brings about more problems. :)

I was planning on filing this in the Debian bug tracker after this was resolved in case changes needed to be made. Should I go ahead and file it now?

Thanks!
Jacob

[James Westby (james-w)]

Hi Jacob,

Thanks for working on this, it looks much better now.

I assume to fix the lintian warning you just deleted the "-" at the start of
that line? If so, then that will cause problems. Usually the way to fix this is
to call "distclean" as "[ ! -f Makefile ] || $(MAKE) distclean" which handles
the usual case of the Makefile not being there as ./configure hasn't been run
without masking other errors.

(Did you know you can get lintian to tell you more about each problem?
I usually run it as "lintian -iIv" which gives lots of possible issues and lots
of information about each.)

I think you can file the bug now, and a bug about the Vcs-Browser change you
made would be good as well.

As for the rest of the changes, I have a few comments/questions.

  * Seeing the modifications to the Makefiles is odd, do you know why they are
     changing?
  * It is against Ubuntu policy to modify the Standards-Version in a package that
     originates from Debian, as there is little use for this change, and it is not done
     across the board, so it just adds noise and can lead to spurious conflicts.
  * Why did you change the comment in the desktop file as well?
  * Removing the extension from the icon name is good, but is there not a display-capplet
     icon installed? Is it in the source package and just missed from being installed?
  * Please remove the extra new-line from the Build-Depends field, it doesn't cause any
     harm, but it needn't be there.

If you can clear up these issues, or explain why they are the way they are then I will
happily sponsor this change.

Thanks,

James

[Jacob Peddicord (jpeddicord)]

James,

Odd, I tried using [ -f Makefile ] earlier and it didn't work, but it seems to be working fine now. Changed.

I'm not entirely sure why the source Makefiles are changing in the diffs, but it could be because of an automake version difference (see the comments at the top of the diff about automake). This is actually present in the in the current version in the archives as well.

Reset Standards-Version and the Build-Depends lines.

I changed the desktop comment because it sounded repetitive to have a name and comment with "screens" used twice, but since it really sounds fine as it was I've changed it back to reduce noise. :)

The source package does not include an icon at all, and the one it was previously referencing in the desktop file did not exist. I chose display because it was the most obvious choice and looks to be already present in most icon themes.

I'll file those Debian bugs in a little bit.
Let me know if anything else needs changed. I think I'm learning more about packaging in this report than I have been reading wiki pages. :P

Thanks again,
Jacob

[James Westby (james-w)]

Uploaded, thanks for your contribution.

One last thing I did was to add "(LP: #317894)" so that it was clear what
bug you were fixing. An added bonus is that launchpad will take care of
closing this bug for us, as you will see in a moment.

Thanks,

James

[Launchpad Janitor (janitor)]

This bug was fixed in the package grandr - 0.1+git20080326-1ubuntu2

---------------
grandr (0.1+git20080326-1ubuntu2) jaunty; urgency=low

  * debian/grandr.desktop:
    - Changed OnlyShowIn=GNOME to NotShowIn=KDE (LP: #317894)
    - Fixed icon
  * debian/control: fix git browser URL
  * debian/rules: don't ignore all errors from make

 -- Jacob Peddicord <email address hidden> Mon, 19 Jan 2009 10:04:35 -0500

[Jacob Peddicord (jpeddicord)]

Oh whoops, sorry, I had meant to add that but it just slipped my mind. Thanks!