Footer from contact via web email contains an extra new line character

Bug #317701 reported by Diogo Matsubara
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Curtis Hovey

Bug Description

See https://pastebin.canonical.com/12781/ the footer says:

"This message was sent from Launchpad by the user
Diogo Matsubara (https://staging.launchpad.net/~matsubara)
using the "Contact this team" link on the Launchpad API Hackers team
page to each
 member directly."

There's an extra new line in between "page to each" and "member directly"

Revision history for this message
Diogo Matsubara (matsubara) wrote :

Hi Curtis, found this while QA'ing r7522. I don't think it's a blocker for that landing but it'd be nice if you could squeeze a fix in.
Thanks

Changed in launchpad-registry:
assignee: nobody → sinzui
milestone: none → 2.2.1
Revision history for this message
Curtis Hovey (sinzui) wrote :

This is kind of intentional because we are forcing the line wrap. I'm sure I can optimise the footer so that it will not be wrapped for most cases.

Changed in launchpad-registry:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Björn Tillenius (bjornt) wrote : Re: [Bug 317701] Re: Footer from contact via web email contains an extra new line character

On Fri, Jan 16, 2009 at 01:44:30AM -0000, Curtis Hovey wrote:
> This is kind of intentional because we are forcing the line wrap. I'm
> sure I can optimise the footer so that it will not be wrapped for most
> cases.

Is it really intentional that you consider that "page to each member
directly." doesn't fit on one line? That seems like a bug in the code
that wraps the footer to me. Are you using MailWrapper to wrap the text,
or something else?

    subscribe bjornt

Revision history for this message
Curtis Hovey (sinzui) wrote : Re: [Bug 317701] Re: Footer from contact via web email contains an extra new line character

On Fri, 2009-01-16 at 08:43 +0000, Björn Tillenius wrote:
> Is it really intentional that you consider that "page to each member
> directly." doesn't fit on one line? That seems like a bug in the code
> that wraps the footer to me. Are you using MailWrapper to wrap the text,
> or something else?

MailWrapper is wrapping the text. The inserted team name almost always
make the line too long. I'm going to move the text after the team name
to next line so the wrapping looks natural.

Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Triaged → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fix committed in launchpad/devel rev 7623.

Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fix released in Launchpad 2.2.1.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.