move generated code in startup.py into a library
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
grok |
Fix Released
|
Medium
|
Michael Haubenwallner |
Bug Description
startup.py as created by grokproject contains code that looks generic enough to push into a library.
We have a few options. We could put this code into grok itself. This would require that certain versions of grokproject *have* to have a recent-enough version of Grok, but I think that this is acceptable. If we move it into grok itself, I propose a grok.startup module.
Alternatively we could consider a grokcore.startup package that contains this code instead - with a bit of care this could make newer versions of grokproject still compatible with older versions of Grok as it'd put in a setup.py requirement for grokcore.startup. The Grok core would also have this requirement, so if newer versions of Grok are installed it doesn't need to add grokcore.startup into the project's setup.py anymore (grokproject could detect this).
I'm inclined towards the grokcore.startup approach.
Changed in grok: | |
assignee: | nobody → d2m |
importance: | Undecided → Medium |
milestone: | none → 1.0 |
status: | New → Confirmed |
Changed in grok: | |
status: | Fix Committed → Fix Released |
Yep, I'd also prefer grokcore.startup over grok.startup. Michael, what do you think? Let's start it, okay?