Attempting to set redirection_url to a tuple instead of a string in login machinery

[Stuart Bishop]

As seen with OOPS-46C148 , there is a code path somewhere that passes a
tuple through to the database layer instead of a string.

 affects /products/launchpad

--
Stuart Bishop <email address hidden> http://www.canonical.com/
Canonical Ltd. http://www.ubuntu.com/

[James Henstridge (jamesh)]

If I go to https://launchpad.net/+login, the template code puts the following in the form element:

    <input type="hidden" name="redirection_url" />

So the redirection_url form item will be posted back with a value of "".

If I go to https://launchpad.net/+login?redirction_url= (essentially what I'd get for posting an empty redirection_url), The form contains the following:

    <input type="hidden" name="redirection_url" />
    ...
    <!-- Preserve extra query parameters as hidden fields. -->
    <input type="hidden" name="redirection_url" value="" />

This would result in two "redirection_url" items being posted back, which is similar to the results observed in the OOPS.

[Steve Alexander (stevea)]

Thanks for the analysis James!

So, there are two bugs here. One is that the +login form is adding an empty redirection_url where there is no need to do so. Another is that the code to preserve extra query parameters is not taking into account the redirection_url value.

The first is more of an aesthetic issue. The second can be fixed to solve this issue.

[Steve Alexander (stevea)]

I want to talk about the design of this subsystem with Salgado in London, so we can check out its design and document it better. I'll commit a trivial workaround for it meanwhile.

[Francis J. Lacoste (flacoste)]

The login code changed so much in the last 4 years that the code paths are now totally different. If there is still a related OOPS, we should open a new bug.