MIR for jflex

[Matthias Klose]

Binary package hint: jflex

needed as a build dependency for cup

a rewrite of jlex, with a 2008 release. standard java packaging, maintained by the debian java group. rechecked the copyright.

[Loïc Minier (lool)]

Current Ubuntu-specific source doesn't change Maintainer to Ubuntu; I think we can solve this by syncing 1.4.2-1 from unstable; doko, can you confirm all changes are in? It seems to from only looking at the changelog.

dpkg-parsechangelog should be preferred to retrieve the upstream version from changelog.

debian/copyright should mention the exact version of the license as there's no particular grant on moving to newer versions. I found the license to be a reformated GPL-2 with some reformatting changes.
  A random source file doesn't list a particular version in the grant either, for instance src/JFlex/gui/GridPanelConstraint.java:
 * JFlex 1.4.2 *
 * Copyright (C) 1998-2008 Gerwin Klein <email address hidden> *
 * All rights reserved. *
 * *
 * This program is free software; you can redistribute it and/or modify *
 * it under the terms of the GNU General Public License. See the file *
 * COPYRIGHT for more information. *
 * *
 * This program is distributed in the hope that it will be useful, *
 * but WITHOUT ANY WARRANTY; without even the implied warranty of *
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
 * GNU General Public License for more details. *
 * *
 * You should have received a copy of the GNU General Public License along *
 * with this program; if not, write to the Free Software Foundation, Inc., *
 * 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA *

There's one exception: examples/binary/StraightStreamReader.java is version 2 or later.

Stephen Ostermiller doesn't appear in the copyright holders.

Copyright needs to be updated to 2008.

(I also wonder whether you should have default-jdk in Build-Depends since ant is used in clean as much as during build, but I don't think this matters too much in practice since you only have an arch: all package, so build-deps-indep are always installed.)

[Loïc Minier (lool)]

I don't think these points should block promotion to main; these are all relatively minor, but because there's a bunch of them, I think these should be fixed quickly nevertheless.

Matthias, I think you have access to the Debian packaging upstream SVN, could you please fix the copyright issues there?

[Alexander Sack (asac)]

not sure why this hasnt been promoted yet. Loic acked it in https://bugs.edge.launchpad.net/ubuntu/+source/jflex/+bug/315403/comments/2; cup still seems to be dependency wait.

[Martin Pitt (pitti)]

Promoted.