Crash if completer_delims has been set to a unicode string (at least on windows)

Bug #315392 reported by Jörgen Stenarson
2
Affects Status Importance Assigned to Milestone
IPython
Fix Released
Critical
Brian Granger
0.10
Fix Released
Critical
Jörgen Stenarson

Bug Description

I have set completer delims to u" \t\n\"\\'`@$><=;|&{(?" and then I get the attached crashlog on startup.

I believe it is because a unicode strings translate method does not have a delete keyword argument on python2.4.

/Jörgen

Revision history for this message
Jörgen Stenarson (jorgen-stenarson) wrote :
Revision history for this message
Ville M. Vainio (villemvainio) wrote :

IPython should just do str() to convert whatever readline.get_completer_delims gives it.

Revision history for this message
Jörgen Stenarson (jorgen-stenarson) wrote : Re: [Bug 315392] Re: Crash if completer_delims has been set to a unicode string (at least on windows)

Ville M. Vainio skrev:
> IPython should just do str() to convert whatever
> readline.get_completer_delims gives it.
>
But that could fail if get_completer_delims returns a unicode string
with a character that can not be converted to ascii.

Revision history for this message
Jörgen Stenarson (jorgen-stenarson) wrote :

I will work on a quickfix here. It should be ok to just remove any characters from completer_delims that are not ascii.

Changed in ipython:
assignee: nobody → ellisonbg
importance: Undecided → Critical
status: New → Fix Committed
Changed in ipython:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.