Wrong version check in SUHost code
Bug #314047 reported by
Hofman
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Sparkle |
Fix Committed
|
Low
|
Unassigned | ||
Bug Description
In SUHost line 142 the version check is wrong, and will lead to leaks with GC. Moreover, it should use a macro rather than a hard-coded number. It should be:
#if MAC_OS_
Also the version check on line 208 is obsolete as 10.3.x is not supported anymore.
Revision history for this message
| Andy Matuschak (andymatuschak) wrote | #1 |
| Changed in sparkle: | |
| importance: | Undecided → Low |
| milestone: | none → 1.5 |
| status: | New → Confirmed |
| status: | Confirmed → Fix Committed |
To post a comment you must log in.
Aha! Good catch. Fixed in 327.