XXX: hardcoded values in albums tab

Bug #313799 reported by Matt Layman
2
Affects Status Importance Assigned to Milestone
Entertainer Media Center
Fix Released
Medium
Samuel Buffet

Bug Description

entertainerlib/frontend/gui/tabs/albums_tab.py lines 39-42:

            # XXX: laymansterms - This is "less than elegant." I'm not fixing
            # ImageMenu right now so we can't get rid of tex_size_x and y yet.
            # We really need to eliminate the concept tex_size_y, but it will
            # have to wait for now.

ImageMenu takes the vertical hieght for its item size but that value should probably be calculated relative to the width desired and the size of the content. Because ImageMenu can't handle that right now, some hard values exist in the albums tab that probably shouldn't.

Tags: tech-debt
Matt Layman (mblayman)
Changed in entertainer:
importance: Undecided → Medium
status: New → Triaged
Changed in entertainer:
assignee: nobody → samuel-buffet
status: Triaged → In Progress
Changed in entertainer:
status: In Progress → Fix Committed
Matt Layman (mblayman)
Changed in entertainer:
milestone: none → entertainer-0.5
Matt Layman (mblayman)
Changed in entertainer:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.