XXX: add tab not quite right

Bug #313782 reported by Matt Layman
2
Affects Status Importance Assigned to Milestone
Entertainer Media Center
Triaged
Medium
Unassigned

Bug Description

entertainerlib/frontend/gui/screens/artist_screen.py lines 57-59:

        # XXX: laymansterms - figure this out, why do we need to add directly
        # to the screen instead of the tab group, why is the positioning
        # messed up when these are commented out. This should be done in add_tab

For some reason a tab object must be added to a tab group and the screen. When trying to add the tab to the tab group through the add_tab method, something about the screen's positioning gets messed up. This needs to be fixed so that the tab/tab_group API doesn't have to add a tab in two different places.

Tags: tech-debt
Matt Layman (mblayman)
Changed in entertainer:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Samuel Buffet (samuel-buffet) wrote :

Agreed, I've refactored the scalable Tab group that way :)

Changed in entertainer:
assignee: nobody → samuel-buffet
status: Triaged → In Progress
Revision history for this message
Samuel Buffet (samuel-buffet) wrote :

This has been already fixed by Matt (I think)

Changed in entertainer:
status: In Progress → Fix Committed
Revision history for this message
Samuel Buffet (samuel-buffet) wrote :

No, this is not fixed, but this part of the code has moved to the Screen Class

Changed in entertainer:
status: Fix Committed → Triaged
Changed in entertainer:
assignee: Samuel Buffet (samuel-buffet) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.