selftest upload reports Old server API in use: <bzrlib.transport.ftp.UnavailableFTPServer object>, setUp() takes exactly 1 argument (2 given)

[Gary van der Merwe]

If I run bzr selftest upload, I get the following error 38 time:

======================================================================
ERROR: test_upload_revision (bzrlib.plugins.upload.tests.test_upload.TestIncrementalUpload)

vvvv[log from bzrlib.plugins.upload.tests.test_upload.TestIncrementalUpload.test_upload_revision(UnavailableFTPServer)]
50.990 creating repository in file:///tmp/testbzr-OuUY3W.tmp/bzrlib.plugins.upload.tests.test_upload.TestIncrementalUpload.test_upload_revision%28UnavailableFTPServer%29/work/branch/.bzr/.
50.995 creating branch <bzrlib.branch.BzrBranchFormat6 object at 0xbc2fcec> in file:///tmp/testbzr-OuUY3W.tmp/bzrlib.plugins.upload.tests.test_upload.TestIncrementalUpload.test_upload_revision%28UnavailableFTPServer%29/work/branch/.bzr/
51.008 trying to create missing lock '/tmp/testbzr-OuUY3W.tmp/bzrlib.plugins.upload.tests.test_upload.TestIncrementalUpload.test_upload_revision(UnavailableFTPServer)/work/branch/.bzr/checkout/dirstate'
51.009 opening working tree '/tmp/testbzr-OuUY3W.tmp/bzrlib.plugins.upload.tests.test_upload.TestIncrementalUpload.test_upload_revision(UnavailableFTPServer)/work/branch'
51.024 preparing to commit
    INFO Committing to: /tmp/testbzr-OuUY3W.tmp/bzrlib.plugins.upload.tests.test_upload.TestIncrementalUpload.test_upload_revision(UnavailableFTPServer)/work/branch/
51.029 Selecting files for commit with filter []
    INFO Committed revision 1.
51.043 encoding stdout as sys.stdout encoding 'UTF-8'
51.049 opening working tree '/tmp/testbzr-OuUY3W.tmp'

^^^^[log from bzrlib.plugins.upload.tests.test_upload.TestIncrementalUpload.test_upload_revision(UnavailableFTPServer)]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/garyvdm/bzr-upload/wd/upload/tests/test_upload.py", line 337, in test_upload_revision
    self.do_full_upload()
  File "/home/garyvdm/bzr-upload/wd/upload/tests/test_upload.py", line 243, in do_full_upload
    up_url = self.get_transport(self.upload_dir).external_url()
  File "/usr/lib/python2.5/site-packages/bzrlib/tests/__init__.py", line 1790, in get_transport
    t = get_transport(self.get_url(relpath))
  File "/usr/lib/python2.5/site-packages/bzrlib/tests/__init__.py", line 1910, in get_url
    base = self.get_server().get_url()
  File "/usr/lib/python2.5/site-packages/bzrlib/tests/__init__.py", line 1877, in get_server
    raise Exception, "Old server API in use: %s, %s" % (self.__server, e)
Exception: Old server API in use: <bzrlib.transport.ftp.UnavailableFTPServer object at 0xba27a8c>, setUp() takes exactly 1 argument (2 given)

----------------------------------------------------------------------

[Vincent Ladeuil (vila)]

As you found out the bug is in bzr. I already have a patch fixing it pending review (http://bundlebuggy.aaronbentley.com/project/bzr/request/%3Cm2sko7p4jk.fsf%40free.fr%3E), but since yours is more focused I'll approve it instead.

[Vincent Ladeuil (vila)]

Note that *not* having medusa installed while testing bzr-upload is not the best setup :)