permission problems on hfs+ filesystem

[reg]

It seems that bzr has trouble while working on an HFS+ formated partition on Linux.

Please, see below how to reproduce the issue:
--
reg@awa:/work$ pwd
/work
reg@awa:/work$ mount |grep /work
/dev/sda5 on /work type hfsplus (rw,relatime)
reg@awa:/work$ bzr co lp:~ubuntu-mali/lasource/dev testingbzr
reg@awa:/work$ cd testingbzr/
reg@awa:/work/testingbzr$ bzr mv gui/README .
bzr: ERROR: Permission denied: "/work/testingbzr/gui/README/.bzr/branch-format": [Errno 13] Permission denied: u'/work/testingbzr/gui/README/.bzr/branch-format'
--

I have absolutely no problem doing the exact same thing on an ext3 formated partitions.
Also, on the HFS+ one, I get this permission on every file-operation-related command : mv, add, etc.
Once the permission problem is raised, commits always raises the exception.

Now, please note that I'm not much experienced with bzr but I have still confirmed this behavior on another computer.

Bellow, the -Derror trace:
--
reg@awa:/work/testingbzr$ bzr -Derror mv gui/README .
bzr: ERROR: bzrlib.errors.PermissionDenied: Permission denied: "/work/testingbzr/gui/README/.bzr/branch-format": [Errno 13] Permission denied: u'/work/testingbzr/gui/README/.bzr/branch-format'

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 857, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 797, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 499, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/builtins.py", line 539, in run
    tree, rel_names = tree_files(names_list)
  File "/usr/lib/python2.5/site-packages/bzrlib/builtins.py", line 64, in tree_files
    return internal_tree_files(file_list, default_branch)
  File "/usr/lib/python2.5/site-packages/bzrlib/builtins.py", line 89, in internal_tree_files
    tree = WorkingTree.open_containing(osutils.realpath(file_list[0]))[0]
  File "/usr/lib/python2.5/site-packages/bzrlib/workingtree.py", line 325, in open_containing
    control, relpath = bzrdir.BzrDir.open_containing(path)
  File "/usr/lib/python2.5/site-packages/bzrlib/bzrdir.py", line 818, in open_containing
    return BzrDir.open_containing_from_transport(transport)
  File "/usr/lib/python2.5/site-packages/bzrlib/bzrdir.py", line 839, in open_containing_from_transport
    result = BzrDir.open_from_transport(a_transport)
  File "/usr/lib/python2.5/site-packages/bzrlib/bzrdir.py", line 793, in open_from_transport
    redirected)
  File "/usr/lib/python2.5/site-packages/bzrlib/lazy_import.py", line 125, in __call__
    return obj(*args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/transport/__init__.py", line 1616, in do_catching_redirections
    return action(transport)
  File "/usr/lib/python2.5/site-packages/bzrlib/bzrdir.py", line 770, in find_format
    transport, _server_formats=_server_formats)
  File "/usr/lib/python2.5/site-packages/bzrlib/bzrdir.py", line 1593, in find_format
    return format.probe_transport(transport)
  File "/usr/lib/python2.5/site-packages/bzrlib/bzrdir.py", line 1603, in probe_transport
    format_string = transport.get(".bzr/branch-format").read()
  File "/usr/lib/python2.5/site-packages/bzrlib/transport/local.py", line 156, in get
    self._translate_error(e, path)
  File "/usr/lib/python2.5/site-packages/bzrlib/transport/__init__.py", line 316, in _translate_error
    raise errors.PermissionDenied(path, extra=e)
PermissionDenied: Permission denied: "/work/testingbzr/gui/README/.bzr/branch-format": [Errno 13] Permission denied: u'/work/testingbzr/gui/README/.bzr/branch-format'
--

[Robert Collins (lifeless)]

On Tue, 2008-12-30 at 11:44 +0000, reg wrote:
> Public bug reported:
>
> It seems that bzr has trouble while working on an HFS+ formated
> partition on Linux.

I would expect this is a strange (but possibly posix-ok) error code to
opening a file that doesn't exist.

Assuming no damage is occuring to the tree, this should be fixable by
catching the error that is raised as part of our normal branch probing
code.

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[Vincent Ladeuil (vila)]

bzr behavior is well specified when using "native" file systems.
Crossing that frontier is bound to reveal such corner cases.
The main issue for us here is to:
1) be able to reproduce your setup which is doable but not trivial,
2) implement a better file system recognition mechanism which highly non trivial
3) allow a working tree to cross file system boundaries (certainly too complex to be worth
    supporting).