Docs give incorrect advice for setting up bzr+http w/ Apache

[Jean-Baptiste Rouault]

When running bzr branchhttp://bzr.malept.com/bazaar-overlay/ , i get the following error :
bzr: ERROR: Lock not held: LockableFiles(lock, http://bzr.malept.com/.bzr/repository/)

[Mark Lee (malept)]

Confirmed.

[Mark Lee (malept)]

After tracing the error, I think it may be a bug in bzr, mostly because I saw a similar traceback in bug 283479.
Server details:
Bazaar (bzr) 1.9
  Python interpreter: /usr/local/bin/python 2.4.4
  Python standard library: /usr/local/lib/python2.4
  bzrlib: /home/malept/dist/lib/python2.4/site-packages/bzrlib
  Bazaar configuration: /home/malept/.bazaar
  Bazaar log file: /home/malept/.bzr.log

(My) client details:
Bazaar (bzr) 1.10
  Python interpreter: /usr/bin/python 2.5.2
  Python standard library: /usr/lib/python2.5
  bzrlib: /usr/lib/python2.5/site-packages/bzrlib
  Bazaar configuration: /home/malept/.bazaar
  Bazaar log file: /home/malept/.bzr.log

Attaching the bzr.log generated when I ran the following:
BZR_LOG=`pwd`/bzr-lockfiles.log bzr branch -Dhpss -Dlock -Derror -v http://bzr.malept.com/bazaar-overlay/

[Luke-Jr (luke-jr)]

So... no solution in sight? Why does it seem to only be this repo?

[Mark Lee (malept)]

Waiting on comments from the Bazaar team, to see if it's Bazaar or my setup (or both) that's causing the problem.

[Robert Collins (lifeless)]

It looks like you have a smart server running on that http url. I smell
a bug in the lock synchronisation logic in
RemoteBranch/RemoteRepository, particularly as you're reading from it so
no physical locks should be occuring.

-Rob

[Andrew Bennetts (spiv)]

As I wrote in <https://answers.edge.launchpad.net/launchpad-bazaar/+question/56078>:

"""
It appears that the branch is accessible via bzr+http, but the branch's repository isn't (it is only accessible via HTTP).

I think there are two bugs here:

 1) The server is misconfigured. If a branch's repository isn't accessible via the same protocol/connection as the branch itself, then that branch is unusable.
 2) The client doesn't report the problem gracefully or clearly.

You should be able to workaround the misconfiguration by using "nosmart+http://..."
"""

[Mark Lee (malept)]

Andrew:
Thanks for your reply. It was indeed a misconfiguration, as smart server support was not enabled for the shared repository. However, I do remember now why I failed to add it - the mod_rewrite statement in the latest user guide did not work for me (My shared host uses Apache 1.3.x).

Instead of the statement in the user guide (which gave a 500 error):

RewriteRule ^(.*/|)\.bzr/smart$ /srv/example.com/scripts/bzr-smart.fcgi

I used the following:

RewriteRule ^(.*/)?\.bzr/smart$ /srv/example.com/scripts/bzr-smart.fcgi

So in addition to the clearer error message, perhaps the user guide should be updated as well?

[John A Meinel (jameinel)]

Sounds like some inconsistencies in Regex handling between versions of Apache.

Do we know if all versions support ()? to optionally match the group?

I would be happy to switch the documentation to whatever Apache is going to support the best.

[Neil Martinsen-Burrell (nmb)]

According to the Apache 1.3 docs, the regexp is a "Extended Regular Expression" and according to http://en.wikipedia.org/wiki/Regular_expression#POSIX_Extended_Regular_Expressions that will support the conditional match in the rewrite rule.

[Martin Pool (mbp)]

I may be missing something obvious here, but what's wrong with the original version?

()? is very basic regex syntax. Is the problem that not everything supports | for alternatives within a group?

[Mark Lee (malept)]

> ()? is very basic regex syntax. Is the problem that not everything
> supports | for alternatives within a group?

That was my experience.