division for compound units not working properly

[John Salvatier]

These two should be the same, but they are not

>>>(5.2 * eV) / (400.0 * eV)
Quantity(0.013000000000000001), (J)^2
>>>(1.0 * J ) / ( 5.3 * J)
Quantity(0.18867924528301888), (dimensionless)

[John Salvatier (jsalvatier)]

I think I fixed this:

in dimensionality.py I changed the __div__ function and got the correct behavior:

   def __div__(self, other):
        if not isinstance(other, Dimensionality):
            scaling = self.scaling / float(other)
            units = self.units
            dimensions = copy.deepcopy(self._dimensions)
        else:
            units = []
            old = []
            new = []
            for su, ou, od, in zip(self._units, other._units, other._dimensions):
                if (su and ou) and (su != ou):
                    old.append(ou+'^%d'%od)
                    new.append(su+'^%d'%od)
                if ou and not su: units.append(ou)
                else: units.append(su)
            old = '*'.join(old)
            new = '*'.join(new)
            scaling, offset = _udunits.convert(old, new)
            dimensions = self._dimensions - other._dimensions
            compound = copy.deepcopy(self._compound)
            for k, v in other._compound.items():
                if k in self._compound:
                    compound[k] -= v # changed this from += to -=
                else:
                    compound[k] = -v # changed from = v to = -v
        new = self.__class__(units, dimensions, **compound)
        new._scaling = scaling
        new._offset = offset
        return new

[John Salvatier (jsalvatier)]

The only changes above where changing the signs on the compound part

[Darren Dale (dsdale24)]

Thanks John. I applied your change and pushed it to launchpad. You can update your branch by doing:

bzr pull