Merge proposals with unsigned votes should accept the comment

[Barry Warsaw]

I just sent a review to a merge proposal that included a vote. My MUA hiccuped and did not sign the message. The merge proposal processor kicked back a failure message saying "The message you sent included commands to modify the code review, but you didn't sign the message with your OpenPGP key."

I can definitely understand that the vote would be rejected, but unfortunately, the processor also discarded my comment. Fortunately, I keep a copy of all the messages I send so I resent it (but that triggered another bug).

The mp processor should only discard the vote for unsigned messages. There's no harm in accepting the comment, so it should do that.

[Aaron Bentley (abentley)]

The comment is usually connected to the review associated with it. Accepting the comment without accepting the review would be a mistake. If the user decides that they just want to comment, they can send a new comment or re-send the old one if appropriate.

[Tim Penhey (thumper)]

I agree with Aaron on this.

If the email contains commands, and isn't signed, then everything is rejected. The original email is attached, so it should be easy enough to copy or resent signed.