auto adding extension

[Daniël H.]

Automatically adding extension / automatically save as the right file format when selecting a file format in the save (as) >Files of type dialog.

[Milan Boers (milan-boers)]

Yep, I tried that, but I have no idea how. If anyone can help me out, I would love to.

[Roel Huybrechts (rulus)]

I tried fixing this issue, patch attached. Needs testing though.

[Roel Huybrechts (rulus)]

Hmm, I don't know how to merge the two patches, so you should apply this one after the first one.

[Milan Boers (milan-boers)]

Thank you. Added your patches, but there's one little problem.
I save the file with filename "hoi" where filter is .t2k, so it saves as hoi.t2k. That works fine.
But when I do that again, it doen't ask to to overwrite.

[Roel Huybrechts (rulus)]

Yes, I discovered that one too a minute ago, I'll check where it goes wrong. In the mean time, I have another patch for you :)
Sometimes the extension was added twice, this should be fixed with attached patch.

[Milan Boers (milan-boers)]

Thanks :) I just fixed a bug that sometimes the Save wasn't shown when it should be.

[Roel Huybrechts (rulus)]

I forgot to add a revision in the first patch; it's attached now.

[Roel Huybrechts (rulus)]

Patch to dynamically add the extension to the selected file in the save dialog, based on the selected filter. This ensures there will be asked a confirmation before overwriting an existing file.

[Daniël H. (daan-is-here)]

Only add extension when extension not in filename.

[Daniël H. (daan-is-here)]

Maybe make a new variable for the supported extensions in a list? That avoids having to change all things when adding support for a new file format.

[Daniël H. (daan-is-here)]

hm patch doesn't work

[Roel Huybrechts (rulus)]

Improved confirmOverwrite.patch: save as .ot when no extension specified. Note: does not work when manually changing the extension after changing the filter.

[Roel Huybrechts (rulus)]

I guess the best solution is to use the QFileDialog only to select a file/location to save, and show a separate confirmation dialog if that file already exists. Patch against current trunk is attached, needs excessive testing though.

[Milan Boers (milan-boers)]

Added the last patch to rev >= 26

[Roel Huybrechts (rulus)]

Only change saveFilename, update window title and disable save if actually saved the file. Needs testing.

[Roel Huybrechts (rulus)]

And we shouldn't clear the words table when the user pressed New, chose to save changes and then cancelled the operation.

[Milan Boers (milan-boers)]

Added your patched in respectively revision 46 and 47.

[Milan Boers (milan-boers)]

Uhh 47 and 48 I mean :)

[Marten de Vries (marten-de-vries)]

Still the saving dialog does show weird behaviour, and I have at other sources (the ubuntu-nl.org forum) seen complains that the dialog doesn't look native.

I'm going to mark this bug open again, maybe we can simply better use the default dialog of Qt. It doesn't have automatic extension adding, but more apps use it so I think users are used to that behaviour already.

[Marten de Vries (marten-de-vries)]

I fixed it as one in a list of bugs sometime ago. (using the native file dialog.)