closing terminator windows doesn't close the processes within them

[Martin Pool]

 affects terminator

I have a Terminator window and pressed Ctrl+Shift+W to close some tabs.
I can see that the processes within them are still running:

init-+-/usr/bin/termin-+-gnome-pty-helpe
     | |-xdg-open
     | |-zsh---vim---{vim}
     | |-4*[zsh]
     | |-zsh-+-less
     | | `-pstree
     | `-{/usr/bin/termin}

I would have expected they'd get a SIGHUP and that would kill them. At
any rate they are no longer accessible in any way. If I send a SIGHUP
to the zsh parent process of vim, it does exit and the vim process goes
away with it.

--
Martin <http://launchpad.net/~mbp>

[Thomas Hurst (tom.hurst)]

Confirmed; manually closing a tab doesn't send children a SIGHUP. I've pushed a reasonable looking fix to trunk.

[Thomas Hurst (tom.hurst)]

It looks like this might send duplicate HUPs when you close a window :/

[Chris Jones (cmsj)]

Thomas: Needing to manually SIGHUP means we are misbehaving elsewhere, unfortunately.

I've been doing some work on trunk which should prevent us leaving (python and gtk) references to the vte.Terminal objects and thus never GCing them.

poolie: could you branch lp:terminator and confirm?

(stealing the bug and marking In Progress pending confirmations. It seems ok to me, but it's late and there are lots of codepaths at work)

[Chris Jones (cmsj)]

0.12 is out and should fix this, please re-open if it doesn't.

[Michael Lustfield (michaellustfield)]

I'm seeing this behavior in 0.14.

[Chris Jones (cmsj)]

I think this is now fixed in trunk. I have made Terminal::close() specifically send SIGHUP to its forked child. I don't really think it's advisable to try any harder to kill the process.

[Cleanrock (cleanrock)]

This problem still exist in 0.93.
How to reproduce:
Start terminator and do a few splits, then close all windows except one using right mouse button menu => you will see that multiple shell (bash) child processes still exist.

[Chris Jones (cmsj)]

I've just pushed revision 1052 to trunk which explicitly closes each terminal when closing a window, which should fix this.

[Cleanrock (cleanrock)]

This is not fixed in 0.94.
Do a few splits and close some windows using mouse, you will see that their are still extra shells running.

[Steven Vancoillie (steabert)]

In terminator version 0.95, this issue still exists.

Having a look at the python code of terminator, it seems that when one right-clicks and chooses menu-close, the terminal is only deregistered by calling the method deregister_terminal from the terminator class. Adding the line "terminal.close()" before it is removed from the terminals list (at "self.terminals.remove(terminal)") seems to solve the problem for me.

[Chris Jones (cmsj)]

Steven: Thanks for tracking that down, you're right - in the specific case of the context menu, it would not cause children to exit properly. I have updated that codepath to call close() on the Terminal object, so as of r1234 in trunk this should be fixed. It will be in 0.96.