Code duplication for Person RDF
Bug #30793 reported by
Andrew Bennetts
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
See original discussion in bug 5543.
The current RDF generation code for a Person is duplicated for e.g. products and project RDF generation.
At the least, the code duplication should be fixed.
James Henstridge proposes that a better solution would be to generate different RDF that merely references common data for each person, rather than embedding repeated information in the same RDF.
See also bug 360699
Related branches
lp:~sinzui/launchpad/rdf-links-0
- Abel Deuring (community): Approve (code)
-
Diff: 549 lines (+86/-194)13 files modifiedlib/lp/registry/browser/__init__.py (+28/-0)
lib/lp/registry/browser/person.py (+5/-41)
lib/lp/registry/browser/product.py (+6/-21)
lib/lp/registry/browser/productrelease.py (+8/-23)
lib/lp/registry/browser/productseries.py (+5/-21)
lib/lp/registry/browser/project.py (+5/-20)
lib/lp/registry/stories/person/xx-person-rdf.txt (+9/-46)
lib/lp/registry/stories/product/xx-product-rdf.txt (+1/-6)
lib/lp/registry/stories/project/xx-project-rdf.txt (+1/-6)
lib/lp/registry/templates/person-rdf-contents.pt (+3/-4)
lib/lp/registry/templates/product-rdf.pt (+5/-2)
lib/lp/registry/templates/productrelease-rdf.pt (+5/-2)
lib/lp/registry/templates/project-rdf.pt (+5/-2)
| Changed in launchpad: | |
| status: | Unconfirmed → Confirmed |
| affects: | launchpad-foundations → launchpad-registry |
| Changed in launchpad-registry: | |
| importance: | Medium → Low |
| tags: |
added: timeout removed: infrastructure |
Revision history for this message
| Robert Collins (lifeless) wrote | #1 |
| Changed in launchpad-registry: | |
| importance: | Low → High |
Revision history for this message
| Robert Collins (lifeless) wrote | #2 |
| description: | updated |
| tags: | removed: timeout |
| Changed in launchpad-registry: | |
| importance: | High → Low |
| Changed in launchpad-registry: | |
| assignee: | nobody → Curtis Hovey (sinzui) |
| status: | Triaged → In Progress |
| milestone: | none → 10.10 |
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #3 |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad: | |
| assignee: | Curtis Hovey (sinzui) → nobody |
To post a comment you must log in.
High as per zero-oops-policy.
FWIW I agree with jamesh; alternatively eager loading should make it quite fast too.