[Patch] Remaining battery time cannot be translated due to bug in i18n

[Krzysztof Lichota]

Binary package hint: kde-guidance

The KDE power manager tooltip shows untranslated message "hh:mm remaining" and "hh:mm to charge" although the message is in .po file and translated properly.

I have found the problem - the i18n call in source is used improperly - i18n is applied to message _after_ substitution, not before, so message is searched in message catalog with "hh:mm" filled in (and not found).

The following change fixes it:
--- guidance-power-manager.py.orig 2008-12-08 16:17:37.000000000 +0100
+++ guidance-power-manager.py 2008-12-08 16:15:14.000000000 +0100
@@ -682,9 +682,9 @@
             if self.batt_state == "charged":
                 blabel += i18n(" fully charged")
             elif self.batt_state == "charging":
- blabel += i18n(" %i:%02ih to charge" % (remain_h,remain_m))
+ blabel += unicode(i18n(" %i:%02ih to charge")) % (remain_h,remain_m)
             elif self.batt_state == "discharging":
- blabel += i18n(" %i:%02ih remaining" % (remain_h,remain_m))
+ blabel += unicode(i18n(" %i:%02ih remaining")) % (remain_h,remain_m)
             self.BattMainLabel.setText(blabel)

             # update tray icon if needed

I attach diff which fixes all similar broken i18n calls in powermanager.py.

I have tested the change to "time remaining" and "time to charge". I cannot test the other 2 calls as I do not have 2 cores not 2 batteries.

[goto (gotolaunchpad)]

Are the fixes upstream already?

[Krzysztof Lichota (krzysiek-launchpad-ubuntu-com)]

2008/12/8 goto <email address hidden>:
> Are the fixes upstream already?

I wasn't able to locate upstream. If you can point me to mailing list
or bug tracker for Guidance, I will submit it there.

[Sebastian Kügler (sebasje)]

For correct translation, you should use KGlobal here, rather than this hacky way:

KGlobal::locale()->prettyFormatDuration(msecs)

Powermanager is in KDE's extragear, http://websvn.kde.org/trunk/extragear/utils/guidance-power-manager/
I think Jonathan Riddell maintains it.

[Jonathan Thomas (echidnaman)]

This is fixed upstream now: http://websvn.kde.org/?view=rev&revision=814391