Equalizer for 0.3

[Michal Dziczkowski]

Exaile 0.3 needs an equalizer.

[reacocard (reacocard)]

assinging to G since he said hed take it in irc yesterday.

[reacocard (reacocard)]

deferring to 0.3.1 due to impending release.

[Dave Aitken (dave-aitken)]

Just finished writing one as a plugin, code is in this branch https://code.launchpad.net/~dave-aitken/exaile/exaile-eq

[Nikola Kotur (kotnik)]

Dave, it doesn't work. I just tested equalizer plugin against Exaile 0.3.0.1, and I get this error:

Traceback (most recent call last):
  File "/usr/share/exaile/plugins/equalizer/__init__.py", line 51, in _enable
    EQ_MAIN = EqualizerPlugin(exaile)
  File "/usr/share/exaile/plugins/equalizer/__init__.py", line 118, in __init__
    exaile.gui.builder.get_object('tools_menu').append(self.MENU_ITEM)
AttributeError: 'Main' object has no attribute 'builder'

[Nikola Kotur (kotnik)]

Dave, line 118 in eqaulizer/__init__.py should be changed from:

exaile.gui.builder.get_object('tools_menu').append(self.MENU_ITEM)

to:

exaile.gui.xml.get_widget('tools_menu').append(self.MENU_ITEM)

And than plugin can be successfully loaded in Exaile 0.3.0.1. But, nevertheless, the plugin is not doing anything to the sound, regardless of the settings.

Is this just a skeleton for the plugin?

[Dave Aitken (dave-aitken)]

Nikola - sorry for the slow reply. Not sure why that gui line change was needed, seemed to work before when I tested it. Unfortunately the equalizer won't work with the default sound engine due to a bug in that, but if you change to the unified (experimental) engine it should function properly. Although the unified sound engine also has some problems of it its own with playback.... so it's all a bit buggy at the minute unfortunately!

[Nikola Kotur (kotnik)]

Dave, thanks for the update.

I'll wait for the equalizer to land in 0.3.1 and than you'll have one happy user more. Unfortunately, I'm not that good with sound, otherwise I'd write it myself. But if I can help in any other way (testing, writing other code), please do not hesitate to ask.

[reacocard (reacocard)]

this was merged to trunk a while back in r2515. normal engine has a slight bug preventing it working, but it works with unified and fixing normal should be easy enough.

[Nikola Kotur (kotnik)]

Thank you Aren.

Testing it (basically, playing music) the whole day now, and it works just as expected.