Fatal: ASSERT: "tio->getChannels() == 2" in file src/engineanalyserqueue.cpp, line 55

Bug #303803 reported by Sean M. Pappalardo
2
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Critical
Nick
1.7
Fix Released
Critical
Nick

Bug Description

Using trunk 2405M on Linux, compiled with tonal=0.

If I try to load a 1-channel (monaural) file (FLAC in this case) right after starting Mixxx, I get Fatal: ASSERT: "tio->getChannels() == 2" in file src/engineanalyserqueue.cpp, line 55.

If I first load a 2-channel file, it's fine. If I then load the 1-channel file, it works fine.

Tags: assert fatal
Revision history for this message
Albert Santoni (gamegod) wrote :

Sean found this bug, looks like your engineanalyser stuff doesn't like mono files. Should maybe dump a qDebug() warning and return in this case instead, in the meantime? (ie. before we figure out what to do with mono files)

Changed in mixxx:
assignee: nobody → adamdavison
importance: Undecided → Critical
status: New → Confirmed
Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

But the mono files work after I first load a stereo one after starting the app.

Revision history for this message
Nick (kousu) wrote :

Well I mean, this fix probably is TOTALLY WRONG, but I'm using Mixxx with it applied now and it seems to work fine. Obviously, this issue needs to be looked at more in depth but for now, for the sake of the user, this might be a good idea?

Revision history for this message
Albert Santoni (gamegod) wrote :

Workaround in committed in r2495. (Just returns and qDebugs a FIXME instead of throwing an assert for non-stereo tracks.) Assigning to kousu so he gets the points.

Changed in mixxx:
assignee: adamdavison → kousue
milestone: none → 1.6.2
status: Confirmed → Fix Committed
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Since tonal is the only thing that cares, and we just switched to using AnalyserQueue for BPM and waveform stuff, this assert needs to go away. I pushed the logic to not work into the TonalAnalyser and removed the assert. I'm assigning this to me and I'll look at it a little further because the symptom of loading a stereo file and then mono working is very weird.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

r2571 fixes this issue.

Changed in mixxx:
milestone: 1.7.0-moving → none
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5064

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.