Please update spec file for Fedora 10

Bug #303796 reported by Steven Harms
4
Affects Status Importance Assigned to Milestone
Terminator
Fix Released
High
Chris Jones

Bug Description

I have update the spec file for Fedora 10, and included gettext as a dependency. Tested and built, and includes pyo files properly according to https://fedoraproject.org/wiki/Packaging/Python

Revision history for this message
Steven Harms (sharms) wrote :
Chris Jones (cmsj)
Changed in terminator:
assignee: nobody → cmsj
importance: Undecided → High
milestone: none → 1.0-beta
status: New → Triaged
Revision history for this message
Ian Weller (ianweller) wrote :

The (latest) spec file at https://bugzilla.redhat.com/show_bug.cgi?id=474036 is much more likely to be correct and standard. There are many issues with this specfile in the context of the Fedora Packaging Guidelines.

I say more "likely" because it is still in the review process. You might wait until that finishes up until you accept that specfile upstream.

Revision history for this message
Chris Jones (cmsj) wrote :

It looks like Terminator is now in Fedora 9 and 10, so we should import their specfile

Changed in terminator:
status: Triaged → In Progress
Chris Jones (cmsj)
Changed in terminator:
milestone: 1.0-beta → 0.12
Revision history for this message
Chris Jones (cmsj) wrote :

Revision 644 on trunk pulls in Fedora 10's specfile with slight modification. I would appreciate some feedback as to whether or not it works. I appreciate you writing a specfile Steven, but I think to reduce maintenance in the future it would be best if I can just grab whatever the latest specfile being used downstream is.
I'm happy to be proven wrong though, I've not touched rpm packaging or Fedora in quite some time.

Changed in terminator:
status: In Progress → Fix Committed
Revision history for this message
Ian Weller (ianweller) wrote :

The changes you made shouldn't break anything as far as I can tell.

I would recommend keeping these .desktop file changes (the patch0 file) upstream because the desktop file validation tools we use follow freedesktop.org standards.

Revision history for this message
Chris Jones (cmsj) wrote :

I had to ditch the patch0 unfortunately, I wanted to remove the X-Bugzilla things anyway, which would have broken the patch.
I'm not convinced it's worth patching out an X- entry anyway - presumably there is no harm in having them present?

Revision history for this message
Chris Jones (cmsj) wrote :

Released in 0.12

Changed in terminator:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.