PTHREAD typo in .pc file

Bug #302003 reported by Ville Ranki
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
mxml (Debian)
Fix Released
Unknown
mxml (Ubuntu)
Fix Released
Low
Unassigned
Nominated for Hardy by Ilya Barygin

Bug Description

Notice @PHTREAD_LIBS@ below. It should be PTHREAD.

$ cat /usr/lib/pkgconfig/mxml.pc
prefix=/usr
exec_prefix=/usr
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: Mini-XML
Description: Lightweight XML support library
Version: 2.4
Libs: -L${exec_prefix}/lib -lmxml @PHTREAD_LIBS@
Cflags: -I${prefix}/include -D_THREAD_SAFE -D_REENTRANT

Tags: patch
Revision history for this message
Ville Ranki (ville-ranki) wrote :

Is the package owner going to do anything? I think this is pretty trivial to fix.

Revision history for this message
aLCHEMY (pep-launchpad) wrote :

No, this is not the solution. It should be:

$ cat /usr/lib/pkgconfig/mxml.pc
prefix=/usr
exec_prefix=/usr
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: Mini-XML
Description: Lightweight XML support library
Version: 2.4
Libs: -L${exec_prefix}/lib -lmxml -lpthread
Cflags: -I${prefix}/include -D_THREAD_SAFE -D_REENTRANT

The error is in the source package mxml-2.4, in the file mxml.pc.in. There is a misspell in line 9:

Libs: @PC_LIBS@ @PHTREAD_LIBS@

Should read:

Libs: @PC_LIBS@ @PTHREAD_LIBS@

If you correct this, generate the packages and install them, all works again.

I think it's an error from mainstream, because I learn about this error in a note in the end of the link:

http://www.warrenweckesser.net/vfgen/menu_download.html

It talks about version 2.5 but in 2.4 still applies.

I hope this can help you to solve the bug.

Changed in mxml (Ubuntu):
assignee: nobody → David Stansby (dstansby)
status: New → In Progress
Revision history for this message
David Stansby (dstansby-deactivatedaccount) wrote :

Here's a patch for version 2.5

Changed in mxml (Ubuntu):
assignee: David Stansby (dstansby) → nobody
status: In Progress → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

Why do you have a new .list file in the debdiff to fix the typo there? Could you send the bug and change to debian?

Changed in mxml (Ubuntu):
importance: Undecided → Low
Changed in mxml (Ubuntu):
assignee: nobody → David Stansby (dstansby)
Changed in mxml (Debian):
status: Unknown → New
Artur Rona (ari-tczew)
tags: added: patch
Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Hi,

As indicated by Sebastien, could you please update your debdiff or explain where the list file comes from?
In the meantime, I'll unsubscribe Ubuntu Sponsors from Universe.
Please subscribe them again when you have an updated debdiff.

Thanks,
Fabrice

Changed in mxml (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
David Stansby (dstansby-deactivatedaccount) wrote :

Sorry for the wait guys, but here's an new debdiff that should be correct.

Changed in mxml (Ubuntu):
status: Incomplete → Confirmed
assignee: David Stansby (dstansby) → nobody
Revision history for this message
StefanPotyra (sistpoty) wrote :

mxml (as found in the archives) already links against pthread, so it will get loaded when the shared object gets loaded.
However mxml doesn't expose the pthread api publically, so @PTHREAD_LIBS@ should be in Libs.private, not in Libs in the first place (to fix static linkage).

However since this only affects static linking, I guess we'll defer that to lucid.

Revision history for this message
David Stansby (dstansby-deactivatedaccount) wrote :

Isn't that a separate problem that should have a new bug filed against it?

Revision history for this message
StefanPotyra (sistpoty) wrote :

What's the other problem then?

Changed in mxml (Debian):
status: New → Fix Released
Revision history for this message
Ilya Barygin (randomaction) wrote :

Fixed in 2.5-2 (patch 03_mispell_mxml.pc.diff) which is in Ubuntu repos since Intrepid.

However, Hardy is still affected, this may be SRU-worthy.

I suggest that the new bug be opened for the Libs vs Libs.private issue if necessary.

Changed in mxml (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.