SUPackageInstaller should respect synchronously option

[David Dauer]

1.5b6:

the corrected method should be

+ (void)performInstallationWithPath:(NSString *)path host:(SUHost *)host delegate:delegate synchronously:(BOOL)synchronously versionComparator:(id <SUVersionComparison>)comparator;
{
 ....

 NSTask *installer = [NSTask launchedTaskWithLaunchPath:installerPath arguments:[NSArray arrayWithObjects:path, nil]];
 if (synchronously) [installer waitUntilExit]; // changed here

 // Known bug: if the installation fails or is canceled, Sparkle goes ahead and restarts, thinking everything is fine.
 [self _finishInstallationWithResult:result host:host error:error delegate:delegate];
}

[Andy Matuschak (andymatuschak)]

This is actually a little trickier than that: making the change suggested would not actually ensure that the installation had completed when the method returned, which the caller could rely upon.

The consequence of this bug is not very significant, though (it affects apps which use .pkgs and which might want to postpone installation), and it would require a lot of work to fix, so I think I'm punting for 1.5.