vmbuilder EC2: /etc/fstab missing trailing newline when built with --part

[Eric Hammond]

When I use the --part option in vmbuilder --ec2 it builds an /etc/fstab without a trailing newline on the last record.

This is probably just a minor nuisance and shouldn't affect much in the way of functionality, but it also should be easy to fix.

I'm currently working off of this branch (with the fixes from ec2exec-fixes)

  https://code.launchpad.net/~nijaba/vmbuilder/ec2exec

I used the following file with --part:

cat >vmbuilder-ec2-32.part <<EOM
root 4096 a1
/mnt 0 a2
swap 1024 a3
/sys 0
EOM

[Eric Hammond (esh)]

Turns out this is already a problem and should be increased in priority.

When walking through the following tutorial,

  http://developer.amazonwebservices.com/connect/entry.jspa?categoryID=100&externalID=1663

the missing newline breaks a command like:

  echo "/dev/sdh /vol xfs noatime 0 0" >> /etc/fstab

I don't think anybody would be considered strange if they expected /etc/fstab to end in a newline.

[Chuck Short (zulcss)]

Relatively easy to fix. Thanks for the bugreport eric.

Regards
chuck

[Loïc Minier (lool)]

Is this still an issue? I looked at the templates for fstab generation, and it wasn't immediately obvious to me that the output would miss a newline (the templates themselves already have a newline!)