Some typing rows not visible

[Topher]

Binary package hint: dvorak7min

For example, try lesson 10 (keys P and G).
Because the number of rows of words to type precisely fills the page available, the bottom row is hidden by the status bar (which displays WPM, % correct, etc.) When you get to the last row, a new "page" of words to type does not appear, because there is only one extra line to type - but this is hidden underneath the status bar. This is the first time I've seen a command-line program have a GUI problem.

This does not happen when View Keyboard is disabled.

I'm using Ubuntu 8.10.

[François Marier (fmarier)]

Hi Topher,

Would you suggest that we fix this bug by removing the last line of this lesson?

Cheers,
Francois

[Topher (hunt-topher)]

Hm - that would probably work. I think the best solution depends on how extensible this application is meant to be.

If there is likelihood that there will be many lessons in the future with exactly 7 lines of typing, or if the program is meant to be user-customizeable, it might be worth adding a couple lines of code to detect if a typing lesson has exactly 7 lines (ie if the last line will be hidden by the status bar) and moving that last line to a second "page".

Otherwise, it's probably more efficient to either remove the last line or add an extra line such that that last line isn't alone down there. (I think there are a couple of 8-line lessons... and the last 2 lines wrap to a second page fine.)

I say this all meekly because I realize I have little sense of how much work would be involved in either solution. I'm not a programmer.

[Topher (hunt-topher)]

Update: I think I may have just found the culprit.
lessons.c spells out all the lessons in advance.
Lines 165-171 contain this particular lesson (lesson 10).
If you added an extra line before line 171 saying
"\x1"
I assume that would tell the lesson to push that extra line onto another page instead of keeping it (hidden) on the bottom of page 1?

Just a suggestion. Again, I'm not a programmer.

[François Marier (fmarier)]

That's a very good point.

I've built a new package with the change you suggested. I have broken up all of the other lessons with more than 6 lines.

This new package is in my PPA:

  deb http://ppa.launchpad.net/fmarier/ubuntu intrepid main

Could you test it and let me know if it fixes your problem?

Thanks,
Francois

[Topher (hunt-topher)]

Thanks Francois -
Yes, this change does fix the problem. Thanks!
 - Topher Hunt

[François Marier (fmarier)]

I have just uploaded version 1.6.1-10 to Debian unstable.

It will be in Ubuntu 9.04.

Cheers,
Francois

[Topher (hunt-topher)]

Another instance of this bug found

[Topher (hunt-topher)]

Sorry for the brief reopening - I thought I found another appearance of this bug but I think it's fixed in your updated version.