OK and Cancel need to be switched about

[Vadim Peretokin]

In the Ubuntu/Gnome version of the program, the OK and Cancel buttons are in the wrong order - they need to be like Cancel | OK, not OK | Cancel.

[Justin Clift (justinclift)]

Looked into this, and the button order is set by GTK rather than Salasaga. So, to change them around, we'd actually have to code against what GTK is doing, which doesn't seem right.

[Vadim Peretokin (vperetokin)]

Where does it do that? I'm not aware of it offering such functionality save
stock buttons which you can place yourself.

[Justin Clift (justinclift)]

Actually, you're right.

Looked at the code quickly, and somehow thought it was working along the lines of "GTK_STOCK_OPEN | GTK_STOCK_CANCEL".

But when looking at it properly after your follow up question, the ordering of the arguments does make a difference.

ie, on line 163 of ide/functions/dialog/display_dialog_text.c:

  text_dialog = GTK_DIALOG(gtk_dialog_new_with_buttons(dialog_title, GTK_WINDOW(main_window), GTK_DIALOG_MODAL, GTK_STOCK_OK, GTK_RESPONSE_ACCEPT, GTK_STOCK_CANCEL, GTK_RESPONSE_REJECT, NULL));

Moving the order of the arguments around does make a difference.

So, they've just been swapped around in everything that seems relevant:

  Done and verified - Empty layer dialog
  Done and verified - Highlight layer dialog
  Done and verified - Image layer dialog
  Done and verified - Mouse layer dialog
  Done and verified - Text layer dialog
  Done and verified - Image crop dialog
  Done and verified - Preferences edit dialog
  Done and verified - New project dialog
  Done and verified - Project properties dialog
  Done and verified - Slide duration dialog
  Done, but verification not possible until this function is fixed and re-enabled - Project crop dialog
  Code changed, but verification not possible until Win32 is working again - Fullscreen screenshot capture
  Code changed, but verification not possible until Win32 is working again - Window screenshot capture

This will be in the Alpha 6 release.

[Vadim Peretokin (vperetokin)]

Thank you!

Keep in mind thought that on Windows it's the other way around, OK | Cancel
is the norm there.

[Justin Clift (justinclift)]

Heh, more platform specific coding then I guess. ;)

[Vadim Peretokin (vperetokin)]

Yes, but in this case, it's actually good - you make the user feel more at
home and apply consistency.