vc-svn.el is a no-op

Bug #30094 reported by era
22
Affects Status Importance Assigned to Milestone
subversion
Fix Released
Unknown
subversion (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

I installed subversion, but it lacks Emacs integration. Here are the full contents of vc-svn.el:

;; This file no longer lives here, it lives in FSF Emacs.
(error
 "http://savannah.gnu.org/cgi-bin/viewcvs/emacs/emacs/lisp/vc-svn.el
  is the new canonical location of vc-svn.el, in the FSF Emacs tree.")

Obviously (or not), no such file ships with emacs21 on Breezy.

Could you roll back to the version which apparently used to exist in this file until emacs21 actually contains the file in question (and/or everyone is using emacs22)?

Revision history for this message
In , Dave Beckett (dajobe) wrote : vc-svn.el

Yes, please revert this change. It caused emacs to fail to save any
version controlled file (svn or not) or do vc operations or allow you to
quit (unsaved changes).

I reverted to the copy of vc-svn.el in 1.1.4-2 and things are working
again.

Thanks

Dave

Revision history for this message
In , Kaloian Doganov (kaloian) wrote : subversion: Removing vc-svn.el really fixes the problem

Package: subversion
Version: 1.2.0-1
Followup-For: Bug #314213

It looks like vc-svn.el made it's way into Emacs CVS and Subversion does
not distribute it anymore. Emacs 22 is not released yet (and will not be
in the next few months). So, please remove vc-svn.el that contains just
an error message. It really renders Emacs unusable on version controlled
directories.

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: powerpc (ppc)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.8-powerpc
Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8)

Versions of packages subversion depends on:
ii db4.2-util 4.2.52-19 Berkeley v4.2 Database Utilities
ii libapr0 2.0.54-4 the Apache Portable Runtime
ii libc6 2.3.2.ds1-22 GNU C Library: Shared libraries an
ii libdb4.2 4.2.52-19 Berkeley v4.2 Database Libraries [
ii libexpat1 1.95.8-3 XML parsing C library - runtime li
ii libldap2 2.1.30-11 OpenLDAP libraries
ii libneon24 0.24.7.dfsg-2 An HTTP and WebDAV client library
ii libssl0.9.7 0.9.7g-1 SSL shared libraries
ii libsvn0 1.2.0-1 shared libraries used by Subversio
ii libxml2 2.6.16-7 GNOME XML library
ii patch 2.5.9-2 Apply a diff file to an original
ii zlib1g 1:1.2.2-7 compression library - runtime

subversion recommends no packages.

-- no debconf information

Revision history for this message
In , Dwhedon-users (dwhedon-users) wrote : subversion Debian ci: r326 - trunk/debian

tags 314213 pending
thanks

Author: dwhedon
Date: 2005-07-20 02:56:10 +0000 (Wed, 20 Jul 2005)
New Revision: 326

Modified:
   trunk/debian/changelog
   trunk/debian/rules
Log:

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2005-07-15 04:42:37 UTC (rev 325)
+++ trunk/debian/changelog 2005-07-20 02:56:10 UTC (rev 326)
@@ -2,6 +2,7 @@

   * New upstream release.
   * debian/new-upstream.sh : New file.
+ * Do not install vc-svn.el (closes: #314213)

  -- David Kimdon <email address hidden> Thu, 14 Jul 2005 20:50:11 -0700

Modified: trunk/debian/rules
===================================================================
--- trunk/debian/rules 2005-07-15 04:42:37 UTC (rev 325)
+++ trunk/debian/rules 2005-07-20 02:56:10 UTC (rev 326)
@@ -300,10 +300,9 @@
   $(DEB_BUILDDIR)/README \
   debian/subversion/usr/share/doc/subversion/

- # Install emacs scripts.
+ # Install emacs script.
  install -d debian/subversion/usr/share/emacs/site-lisp/
  install -m 0644 \
- $(DEB_BUILDDIR)/contrib/client-side/vc-svn.el \
   $(DEB_BUILDDIR)/contrib/client-side/psvn/psvn.el \
   debian/subversion/usr/share/emacs/site-lisp/

Revision history for this message
In , Dwhedon-users (dwhedon-users) wrote : subversion Debian ci: r332 - trunk/debian

tags 314213 pending
tags 315100 pending
thanks

Author: dwhedon
Date: 2005-07-20 04:05:11 +0000 (Wed, 20 Jul 2005)
New Revision: 332

Modified:
   trunk/debian/changelog
Log:
#315100 is closed as well.

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2005-07-20 03:58:32 UTC (rev 331)
+++ trunk/debian/changelog 2005-07-20 04:05:11 UTC (rev 332)
@@ -2,7 +2,7 @@

   * New upstream release.
   * debian/new-upstream.sh : New file.
- * Do not install vc-svn.el (closes: #314213)
+ * Do not install vc-svn.el (closes: #314213, #315100)
   * Autoload psvn.el by default. (closes: #223303, #305953)
   * Remove hard-coded DEB_BUILDDIR from debian/rules.
   * Enable javahl bindings by default (closes: #271125)

Revision history for this message
In , Romain Francoise (rfrancoise) wrote : Re: Bug#324633: emacs-snapshot-gtk: cannot save files in subversion work area

reassign 324633 subversion
merge 324633 314213
kthxbye

"W. Borgert" <email address hidden> writes:

> When opening a file for reading - but worse - when trying to
> save it, I get the following message:
> "http://savannah.gnu.org/cgi-bin/viewcvs/emacs/emacs/lisp/vc-svn.el
> is the new canonical location of vc-svn.el, in the FSF Emacs
> tree."

Known bug in subversion, reassigning.

--
  ,''`.
 : :' : Romain Francoise <email address hidden>
 `. `' http://people.debian.org/~rfrancoise/
   `-

Revision history for this message
In , Ftlerror-guest (ftlerror-guest) wrote : subversion Debian ci: r356 - trunk/debian

tags 314213 pending
tags 315100 pending
tags 324633 pending
tags 223303 pending
tags 235905 pending
tags 305953 pending
thanks

Author: ftlerror-guest
Date: 2005-09-03 15:59:28 +0000 (Sat, 03 Sep 2005)
New Revision: 356

Modified:
   trunk/debian/changelog
   trunk/debian/rules
Log:
* Updated changelog to close all pending bugs
* Fixed rules, our python stuff is no longer auto-generated =)

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2005-09-03 14:05:17 UTC (rev 355)
+++ trunk/debian/changelog 2005-09-03 15:59:28 UTC (rev 356)
@@ -28,8 +28,8 @@
     on the 'tools' section of the repository on svn.debian.org

   [ David Kimdon ]
- * Do not install vc-svn.el (closes: #314213, #315100)
- * Autoload psvn.el by default. (closes: #223303, #305953)
+ * Do not install vc-svn.el (closes: #314213, #315100, #324633)
+ * Autoload psvn.el by default. (closes: #223303, #235905, #305953)
   * Remove hard-coded DEB_BUILDDIR from debian/rules.
   * Enable javahl bindings by default (closes: #271125, #323839)

Modified: trunk/debian/rules
===================================================================
--- trunk/debian/rules 2005-09-03 14:05:17 UTC (rev 355)
+++ trunk/debian/rules 2005-09-03 15:59:28 UTC (rev 356)
@@ -1,5 +1,7 @@
 #!/usr/bin/make -f

+
+export LANG=C
 ENABLE_JAVAHL=yes

 PWD := $(shell pwd)
@@ -229,7 +231,7 @@
   usr/lib/python$(PYTHON_VER)/

  install -d debian/$(PYTHON_PKG)/usr/share/doc/$(PYTHON_PKG)
- install -m 0644 debian/pythonX.Y-subversion.README.Debian \
+ install -m 0644 debian/python2.3-subversion.README.Debian \
   debian/$(PYTHON_PKG)/usr/share/doc/$(PYTHON_PKG)/README.Debian

  # Install files for 'subversion' package.

Revision history for this message
In , Guilherme de S. Pastore (fatalerror) wrote : Bug#314213: fixed in subversion 1.2.3a-1
Download full text (7.3 KiB)

Source: subversion
Source-Version: 1.2.3a-1

We believe that the bug you reported is fixed in the latest version of
subversion, which is due to be installed in the Debian FTP archive:

libapache2-svn_1.2.3a-1_i386.deb
  to pool/main/s/subversion/libapache2-svn_1.2.3a-1_i386.deb
libsvn-core-perl_1.2.3a-1_i386.deb
  to pool/main/s/subversion/libsvn-core-perl_1.2.3a-1_i386.deb
libsvn-javahl_1.2.3a-1_i386.deb
  to pool/main/s/subversion/libsvn-javahl_1.2.3a-1_i386.deb
libsvn0-dev_1.2.3a-1_i386.deb
  to pool/main/s/subversion/libsvn0-dev_1.2.3a-1_i386.deb
libsvn0_1.2.3a-1_i386.deb
  to pool/main/s/subversion/libsvn0_1.2.3a-1_i386.deb
python2.3-subversion_1.2.3a-1_i386.deb
  to pool/main/s/subversion/python2.3-subversion_1.2.3a-1_i386.deb
subversion-tools_1.2.3a-1_all.deb
  to pool/main/s/subversion/subversion-tools_1.2.3a-1_all.deb
subversion_1.2.3a-1.diff.gz
  to pool/main/s/subversion/subversion_1.2.3a-1.diff.gz
subversion_1.2.3a-1.dsc
  to pool/main/s/subversion/subversion_1.2.3a-1.dsc
subversion_1.2.3a-1_i386.deb
  to pool/main/s/subversion/subversion_1.2.3a-1_i386.deb
subversion_1.2.3a.orig.tar.gz
  to pool/main/s/subversion/subversion_1.2.3a.orig.tar.gz

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guilherme de S. Pastore <email address hidden> (supplier of updated subversion package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 9 Sep 2005 14:57:03 -0300
Source: subversion
Binary: libsvn-core-perl libapache2-svn libsvn0 libsvn-javahl python2.3-subversion subversion-tools libsvn0-dev subversion
Architecture: source i386 all
Version: 1.2.3a-1
Distribution: unstable
Urgency: low
Maintainer: Guilherme de S. Pastore <email address hidden>
Changed-By: Guilherme de S. Pastore <email address hidden>
Description:
 libapache2-svn - apache modules for Subversion (aka. svn)
 libsvn-core-perl - perl bindings for Subversion (aka. svn)
 libsvn-javahl - java bindings for Subversion (aka. svn)
 libsvn0 - shared libraries used by Subversion (aka. svn)
 libsvn0-dev - development files for Subversion (aka. svn) libraries
 python2.3-subversion - python modules for interfacing with Subversion (aka. svn)
 subversion - advanced version control system (aka. svn)
 subversion-tools - assorted tools related to Subversion (aka. svn)
Closes: 215083 218185 223303 235905 271125 305953 310519 314154 314213 314381 315100 316133 316143 316227 320417 320572 322257 323376 323839 324037 324633 326079
Changes:
 subversion (1.2.3a-1) unstable; urgency=low
 .
   * Welcome the Debian Subversion Team (Closes: #322257)
 .
   [ Guilherme de S. Pastore ]
   * New upstream release (Closes: #320417)
     - tarball repackaged without svnbook, as it's licensed under
      ...

Read more...

Revision history for this message
In , Guilherme de S. Pastore (fatalerror) wrote : Bug#324633: fixed in subversion 1.2.3a-1
Download full text (7.3 KiB)

Source: subversion
Source-Version: 1.2.3a-1

We believe that the bug you reported is fixed in the latest version of
subversion, which is due to be installed in the Debian FTP archive:

libapache2-svn_1.2.3a-1_i386.deb
  to pool/main/s/subversion/libapache2-svn_1.2.3a-1_i386.deb
libsvn-core-perl_1.2.3a-1_i386.deb
  to pool/main/s/subversion/libsvn-core-perl_1.2.3a-1_i386.deb
libsvn-javahl_1.2.3a-1_i386.deb
  to pool/main/s/subversion/libsvn-javahl_1.2.3a-1_i386.deb
libsvn0-dev_1.2.3a-1_i386.deb
  to pool/main/s/subversion/libsvn0-dev_1.2.3a-1_i386.deb
libsvn0_1.2.3a-1_i386.deb
  to pool/main/s/subversion/libsvn0_1.2.3a-1_i386.deb
python2.3-subversion_1.2.3a-1_i386.deb
  to pool/main/s/subversion/python2.3-subversion_1.2.3a-1_i386.deb
subversion-tools_1.2.3a-1_all.deb
  to pool/main/s/subversion/subversion-tools_1.2.3a-1_all.deb
subversion_1.2.3a-1.diff.gz
  to pool/main/s/subversion/subversion_1.2.3a-1.diff.gz
subversion_1.2.3a-1.dsc
  to pool/main/s/subversion/subversion_1.2.3a-1.dsc
subversion_1.2.3a-1_i386.deb
  to pool/main/s/subversion/subversion_1.2.3a-1_i386.deb
subversion_1.2.3a.orig.tar.gz
  to pool/main/s/subversion/subversion_1.2.3a.orig.tar.gz

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guilherme de S. Pastore <email address hidden> (supplier of updated subversion package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 9 Sep 2005 14:57:03 -0300
Source: subversion
Binary: libsvn-core-perl libapache2-svn libsvn0 libsvn-javahl python2.3-subversion subversion-tools libsvn0-dev subversion
Architecture: source i386 all
Version: 1.2.3a-1
Distribution: unstable
Urgency: low
Maintainer: Guilherme de S. Pastore <email address hidden>
Changed-By: Guilherme de S. Pastore <email address hidden>
Description:
 libapache2-svn - apache modules for Subversion (aka. svn)
 libsvn-core-perl - perl bindings for Subversion (aka. svn)
 libsvn-javahl - java bindings for Subversion (aka. svn)
 libsvn0 - shared libraries used by Subversion (aka. svn)
 libsvn0-dev - development files for Subversion (aka. svn) libraries
 python2.3-subversion - python modules for interfacing with Subversion (aka. svn)
 subversion - advanced version control system (aka. svn)
 subversion-tools - assorted tools related to Subversion (aka. svn)
Closes: 215083 218185 223303 235905 271125 305953 310519 314154 314213 314381 315100 316133 316143 316227 320417 320572 322257 323376 323839 324037 324633 326079
Changes:
 subversion (1.2.3a-1) unstable; urgency=low
 .
   * Welcome the Debian Subversion Team (Closes: #322257)
 .
   [ Guilherme de S. Pastore ]
   * New upstream release (Closes: #320417)
     - tarball repackaged without svnbook, as it's licensed under
      ...

Read more...

Revision history for this message
era (era) wrote :

I installed subversion, but it lacks Emacs integration. Here are the full contents of vc-svn.el:

;; This file no longer lives here, it lives in FSF Emacs.
(error
 "http://savannah.gnu.org/cgi-bin/viewcvs/emacs/emacs/lisp/vc-svn.el
  is the new canonical location of vc-svn.el, in the FSF Emacs tree.")

Obviously (or not), no such file ships with emacs21 on Breezy.

Could you roll back to the version which apparently used to exist in this file until emacs21 actually contains the file in question (and/or everyone is using emacs22)?

Revision history for this message
era (era) wrote :

As an intermediate workaround, I downloaded the current version from Savannah. I had to edit a couple of places to get it to work with Ubuntu emacs21.

@@ -117,7 +117,8 @@
       (let ((status
              (condition-case nil
                  ;; Ignore all errors.
- (vc-svn-command t t file "status" "-v")
+ ;(vc-svn-command t t file "status" "-v")
+ (vc-svn-command t 255 file "status" "-v")
                ;; Some problem happened. E.g. We can't find an `svn'
                ;; executable. We used to only catch `file-error' but when
                ;; the process is run on a remote host via Tramp, the error
@@ -196,9 +197,9 @@
                                          file
                                        (file-name-directory file)))))

-(defalias 'vc-svn-could-register 'vc-svn-responsible-p
- "Return non-nil if FILE could be registered in SVN.
-This is only possible if SVN is responsible for FILE's directory.")
+(defalias 'vc-svn-could-register 'vc-svn-responsible-p)
+; "Return non-nil if FILE could be registered in SVN.
+;This is only possible if SVN is responsible for FILE's directory.")

 (defun vc-svn-checkin (file rev comment)
   "SVN-specific version of `vc-backend-checkin'."

In addition, here's what I added to my .emacs to get it to work:

(defun vc-svn-registered (f)
  (when (file-readable-p (expand-file-name
                          ".svn/entries" (file-name-directory f)))
    (load "vc-svn")
    (vc-svn-registered f)))

(when (and (boundp 'vc-handled-backends)
           ;(file-exists-p "/usr/share/emacs/site-lisp/vc-svn.el"))
           (file-exists-p "/home/era/elisp/vc-svn.el"))
  (setq vc-handled-backends (append vc-handled-backends (list 'SVN))))

(add-to-list 'completion-ignored-extensions ".svn/")

Revision history for this message
era (era) wrote :

In addition, I had to comment out all occurrences of vc-stay-local-p which is not defined in emacs21 vc.el

I'll try to remember to post a working vc-svn.el here once I have confidence that the important features are all working.

Revision history for this message
era (era) wrote :

Seems that Debian opted to simply remove vc-svn.el. However, it would make more sense IMHO to ship a working version of this.

I am aware of psvn, but I actually want both psvn and vc-svn. They work on different levels, and complement each other nicely.

Simon Law (sfllaw)
Changed in subversion:
status: Unconfirmed → Confirmed
Revision history for this message
era (era) wrote : My current ~/elisp/vc-svn.el

As promised earlier (thanks for the reminder!) here is my full vc-svn.el after several months of what I deem as stable but unexciting use. In other words, I have not used all the funky features, but it works for me.

This should continue to correspond to what was on Savannah in late January plus the patches I posted before. If you want them as an attachment too, feel free to request.

Revision history for this message
David Lee Lambert (davidl) wrote :

I'm pretty sure this is what bit me when upgrading from Breezy to Etch. There was a reference to "psvn.el" in ~/.emacs, and Emacs couldn't load a file from the command-line or save any file until I installed a good "vc-svn.el". The only clue was a message in the minibuffer, something like "Couldn't load vc-svn".

Revision history for this message
Steve Kowalik (stevenk) wrote :

This bug has been fixed since Dapper was released, and since Breezy has also been EOL'd, I'm closing this bug.

Changed in subversion:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.