sale order/quotation report doesn't select payment term properly
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Odoo Addons (MOVED TO GITHUB) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Actually there is two bugs in the sale order/quotation report:
1) Strangely, at the beginning, right after "Invoice address :", we find a payment term. It seems a typo since we expect the address here, not the payment term like that. I would simply remove it.
2) Later, in the Payment Terms field, we have the payment term which is right. But the point is that it doesn't select it properly. Indeed: currently, whatever you do to select a different payment term in the sale order form won't change it. The only way you can currently change that payment term is by setting an other payment term to the related sale order partner. But I think we might want to override it directly on the sale order sometimes (or then it should be readonly).
I propose to simply use [[ o.payment_term.name ]] for the field as it will pick up the potentially overrided payment term instead. It will still try to use the partner payment term first because: when you select a sale order partner or when you change its payment term, it will update the sale order payment term. Then you can still override it manually directly in the sale order which is right.
Merge proposal coming soon.
Raphaël Valyi.
fixed since my branch has been merged