[PATCH] Album-less music files don't report metadata over dbus

Bug #300391 reported by Michael Terry
4
Affects Status Importance Assigned to Milestone
Moovida
Invalid
Medium
Unassigned
moovida (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

The dbus bindings don't like it when None is passed and it expects a string. Here's a patch to make sure we hand back valid strings to get_metadata and get_last_played.

To reproduce, get a file without an album, and play it. Then ask for metadata using:
dbus-send --print-reply --dest=com.fluendo.Elisa /com/fluendo/Elisa/Plugins/Poblesec/AudioPlayer com.fluendo.Elisa.Plugins.Poblesec.AudioPlayer.get_metadata

Revision history for this message
Michael Terry (mterry) wrote :
Revision history for this message
Olivier Tilloy (osomon) wrote :

This indeed fails if the currently playing track is from the music library. If the track is being played directly from the filesystem, I get the expected response.

Changed in elisa:
importance: Undecided → Medium
milestone: none → 0.5.x
status: New → Confirmed
Michael Terry (mterry)
tags: added: oem-services
Olivier Tilloy (osomon)
Changed in elisa:
milestone: 0.5.x → none
tags: added: patch-forwarded-upstream
Revision history for this message
dino99 (9d9) wrote :

The latest free moovida 1.09 does not get any maintenance since a while. Now moovidadb.com is supporting Linux and support can be found at : http://www.fluendo.com/faq/

Changed in moovida:
status: Confirmed → Invalid
Changed in moovida (Ubuntu):
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.