HTTP transport does not use authentication.conf unless you supply a user name.

Bug #300347 reported by Adrian Wilkins
2
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
Vincent Ladeuil

Bug Description

If you add a section to authentication.conf for an http server, the information is not used unless you state the user name in the URL.

The user reference states otherwise.
http://doc.bazaar-vcs.org/bzr.dev/en/user-reference/bzr_man.html#authentication-settings

"Once the relevant credentials are declared in this file you may use branch urls without embedding passwords (security hazard) or even users (enabling sharing of your urls with others)."

Explicitly stating the user name in the URL picks up the password from the section. Tracing filesystem access during a bzr session using a plain URL with no user name reveals that authentication.conf is not even accessed.

I had a look at the code but the transport constructors are a fairly complex area and I'm not confident of my ability to both grok it and produce a patch that will satisfy all concerned.

My naive implementation (without tests) is attached.

Revision history for this message
Adrian Wilkins (adrian-wilkins) wrote :
Revision history for this message
Adrian Wilkins (adrian-wilkins) wrote :

Attached log

Sections are seperated with

<<< comments like this >>>

Revision history for this message
Vincent Ladeuil (vila) wrote :

Thanks for the detailed report, there are other related bugs that I need to fix, stay tuned :)

Changed in bzr:
assignee: nobody → vila
importance: Undecided → Medium
status: New → Confirmed
Vincent Ladeuil (vila)
Changed in bzr:
status: Confirmed → Fix Committed
Vincent Ladeuil (vila)
Changed in bzr:
milestone: none → 1.11rc1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.