Invalid property value for Subversion property bzr:revision-info:

[nicholas a. evans]

bzr 1.9, bzr-svn 0.15

While trying to svn-import a repo, I got the following:

1771.747 Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 893, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 839, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 539, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 853, in ignore_pipe
    result = func(*args, **kwargs)
  File "/home/nevans/.bazaar/plugins/svn/__init__.py", line 281, in run
    keep=keep, incremental=incremental)
  File "/home/nevans/.bazaar/plugins/svn/convert.py", line 202, in convert_repository
    inter.fetch(branches=existing_branches)
  File "/home/nevans/.bazaar/plugins/svn/fetch.py", line 834, in fetch
    self._fetch_switch(self.source.transport.get_svn_repos_root(), needed, pb)
  File "/home/nevans/.bazaar/plugins/svn/fetch.py", line 779, in _fetch_switch
    report_inventory_contents(reporter, parent_inv, parent_revnum, start_empty)
  File "/home/nevans/.bazaar/plugins/svn/fetch.py", line 602, in report_inventory_contents
    reporter.finish()
  File "/home/nevans/.bazaar/plugins/svn/fetch.py", line 108, in close
    self._close()
  File "/home/nevans/.bazaar/plugins/svn/fetch.py", line 234, in _close
    self.editor._finish_commit()
  File "/home/nevans/.bazaar/plugins/svn/fetch.py", line 420, in _finish_commit
    (rev, signature) = self._get_revision(self.revid)
  File "/home/nevans/.bazaar/plugins/svn/fetch.py", line 411, in _get_revision
    self.revmeta.revnum, rev)
  File "/home/nevans/.bazaar/plugins/svn/mapping.py", line 524, in import_revision
    parse_revision_metadata(metadata[1], rev)
  File "/home/nevans/.bazaar/plugins/svn/mapping.py", line 188, in parse_revision_metadata
    "Missing : in revision metadata")
InvalidPropertyValue: Invalid property value for Subversion property bzr:revision-info: Missing : in revision metadata

I have used bzr-svn on several of the branches in this repo in the past.

[Jelmer Vernooij (jelmer)]

Did you perhaps edit some of the bzr-svn file properties in this svn repository?

[nicholas a. evans (nevans)]

I'm not sure which revision is complaining with the error, so I can't look it up to be certain. The ~/.bzr.log file didn't tell me which revision, and my command of python is very poor, so I messed it up (and quickly gave up) when trying to insert my own "mutter". If you give me a correct mutter line, I can give you more info. :-)

But I think that I'm the only person to use bzr-svn in the repository, and I've never manually edited any of the bzr properties (that I can remember). It's entirely possible that someone else edited the properties (e.g. during an svn merge).

[Jelmer Vernooij (jelmer)]

The best way is to add a try/catch block around line 524 (the call to parse_revision_metadata), e.g.:

try:
            parse_revision_metadata(metadata[1], rev)
except errors.InvalidPropertyValue, e:
            raise Exception("Error in %s:%d" % (branch, revnum))

[Jelmer Vernooij (jelmer)]

Can you still reproduce this with the 0.5 branch? I just fixed a branch similar to this.

[Jelmer Vernooij (jelmer)]

s/branch/*bug*/

[Jelmer Vernooij (jelmer)]

Just reproduced (as a separate bug) and fixed in the 0.5 branch.

[nicholas a. evans (nevans)]

I can still repro with lp:bzr-svn/0.5 r2389. I'll try today to see if I can recreate the scenario in a new (non-private) svn repo. Thanks.

[Jelmer Vernooij (jelmer)]

On Sat, 2009-01-24 at 15:27 +0000, nicholas a. evans wrote:
> I can still repro with lp:bzr-svn/0.5 r2389. I'll try today to see if I
> can recreate the scenario in a new (non-private) svn repo. Thanks.
  status triaged

Can you perhaps just paste the new output with r2389 ? The error should
be a fair bit clearer now.

Cheers,

jelmer
--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

[nicholas a. evans (nevans)]

Oops. I got confused about which bug this was. I can't repro this nor verify the fix, because my I'm still blocked by #300006. Most likely you did fix this one. Sorry.

[nicholas a. evans (nevans)]

Oops. I got confused about which bug this was. I can't repro this nor verify the fix, because I'm still blocked by #300006. Most likely you did fix this one. Sorry.