fix bug in Approve.py
Bug #299780 reported by
Robin J
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Systers-mailman |
Won't Fix
|
Medium
|
Robin J | ||
| Development |
New
|
Undecided
|
Unassigned | ||
Bug Description
I cleaned out some code Ellen wrote about "administrivia" getting held, because it was blocking me msgdata.get('args') wasn't defined I need to go back and figure out what this code really does and how to fix it.
| Changed in systers: | |
| assignee: | nobody → robin-jeffries |
| importance: | Undecided → Medium |
| milestone: | none → testingcomplete |
Revision history for this message
| Robin J (robin-jeffries) wrote | #1 |
| Changed in systers: | |
| status: | New → Won't Fix |
To post a comment you must log in.
Now that I understand the code better, I went back to look at this. This handler is only used for approving messages via email, which we never use. I believe that not having this code (the code I removed) means that people can't send an unsubscribe request via email (we are testing that elsewhere), and since we don't advertise that this is possible, that's fine with me (I thought we were deflecting them to systers-owner in any case.)