Crash on message - No NULL checking

Bug #298873 reported by BigBrownChunx
2
Affects Status Importance Assigned to Milestone
Pidgin-WebKit
Fix Committed
Undecided
Unassigned

Bug Description

Using the r60 snapshot, getting crashes every time I receive a message.

Need to

Debug log:
(12:17:38) WebKit: pidgin_webkit_write_conv
(12:17:38) WebKit: name: "<email address hidden>", old_name: "(null)"
(12:17:38) WebKit: name: "<email address hidden>", alias: "Jeremy", flags 0x2
(12:17:38) WebKit: message: "it just makes them disappear 'til you run them again :P"
(12:17:38) WebKit: get_webkit
(12:17:38) WebKit: write_conv: It's an IM
(12:17:38) WebKit: write_conv: first message in
(12:17:38) WebKit: replace_message_tokens

Backtrace:
#0 0xb7240c03 in strchr () from /lib/libc.so.6
#1 0xb6bc58d3 in replace_message_tokens (text=0x0, len=0, conv=0x9afc748,
    name=0x9d30f38 "<email address hidden>", alias=0xb08380d0 "Jeremy",
    message=0x98dc120 "it just makes them disappear 'til you run them again :P", flags=PURPLE_MESSAGE_RECV, mtime=1226877732) at webkit.c:136
#2 0xb6bc5fdc in pidgin_webkit_write_conv (conv=0x9afc748,
    name=0x9d30f38 "<email address hidden>", alias=0xb08380d0 "Jeremy",
    message=0x9d30ec8 "it just makes them disappear 'til you run them again :P", flags=PURPLE_MESSAGE_RECV, mtime=1226877732) at webkit.c:924
#3 0xb739c541 in purple_conversation_write () from /usr/lib/libpurple.so.0
#4 0xb739d809 in purple_conv_im_write () from /usr/lib/libpurple.so.0
#5 0xb73c4de3 in serv_got_im () from /usr/lib/libpurple.so.0
#6 0xb31fea4d in ?? () from /usr/lib/purple-2/libmsn.so

Revision history for this message
Simo Mattila (simom) wrote :

Could you try the newest version in trunk, the NULL-checking was added in r65. Since the replace_message_tokens is called with text=NULL, it looks like that your message style is not properly loaded, anyway.

Simo Mattila (simom)
Changed in pidgin-webkit:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.