Launchpad itself

Attempting to invite a private team fails with "Constraint not satisfied"

Bug #297833 reported by William Grant
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Edwin Grubbs
Launchpad itself 3.1.12

Bug Description

Attempting to invite a private team to (whether or not you have access to it) gives a "Constraint not satisfied" error.

See original description

Related branches

lp:~edwin-grubbs/launchpad/bug-297833-invite-private-team
Curtis Hovey (community): Approve (code)
Michael Hudson-Doyle: Abstain
Diff: 1180 lines (+371/-101)
44 files modified
lib/canonical/launchpad/fields/__init__.py (+36/-12)
lib/lp/archiveuploader/nascentuploadfile.py (+1/-1)
lib/lp/archiveuploader/tests/nascentuploadfile.txt (+71/-0)
lib/lp/bugs/templates/bug-portlet-subscribers.pt (+1/-1)
lib/lp/bugs/templates/bugtarget-filebug-submit-bug.pt (+1/-1)
lib/lp/bugs/templates/bugtarget-portlet-bugfilters.pt (+1/-1)
lib/lp/bugs/templates/bugtarget-portlet-bugtags.pt (+1/-1)
lib/lp/bugs/templates/bugtask-index.pt (+3/-3)
lib/lp/bugs/templates/bugtask-tasks-and-nominations-table-row.pt (+1/-1)
lib/lp/bugs/templates/bugtasks-and-nominations-table.pt (+1/-1)
lib/lp/bugs/templates/official-bug-target-manage-tags.pt (+1/-1)
lib/lp/code/templates/branch-import-details.pt (+1/-1)
lib/lp/code/templates/branch-index.pt (+1/-1)
lib/lp/code/templates/branch-listing.pt (+1/-1)
lib/lp/code/templates/branch-portlet-subscribers.pt (+1/-1)
lib/lp/code/templates/branch-related-bugs-specs.pt (+1/-1)
lib/lp/code/templates/branchmergeproposal-generic-listing.pt (+1/-1)
lib/lp/registry/browser/person.py (+4/-0)
lib/lp/registry/browser/tests/productrelease-views.txt (+1/-1)
lib/lp/registry/browser/tests/team-views.txt (+27/-0)
lib/lp/registry/interfaces/person.py (+4/-6)
lib/lp/registry/stories/teammembership/xx-private-membership.txt (+6/-5)
lib/lp/registry/templates/object-timeline-graph.pt (+1/-1)
lib/lp/registry/templates/person-macros.pt (+1/-1)
lib/lp/registry/templates/product-new.pt (+1/-1)
lib/lp/registry/templates/productrelease-add-from-series.pt (+1/-1)
lib/lp/registry/templates/team-add-my-teams.pt (+2/-0)
lib/lp/registry/templates/teammembership-index.pt (+1/-1)
lib/lp/registry/templates/timeline-macros.pt (+1/-1)
lib/lp/soyuz/templates/archive-edit-dependencies.pt (+1/-1)
lib/lp/soyuz/templates/archive-macros.pt (+1/-1)
lib/lp/soyuz/templates/archive-packages.pt (+1/-1)
lib/lp/soyuz/templates/archive-subscribers.pt (+1/-1)
lib/lp/translations/browser/language.py (+8/-0)
lib/lp/translations/stories/distroseries/xx-distroseries-templates.txt (+56/-13)
lib/lp/translations/stories/productseries/xx-productseries-templates.txt (+27/-18)
lib/lp/translations/stories/standalone/xx-language.txt (+68/-7)
lib/lp/translations/templates/language-index.pt (+9/-4)
lib/lp/translations/templates/object-templates.pt (+20/-3)
lib/lp/translations/templates/pofile-export.pt (+1/-1)
lib/lp/translations/templates/pofile-translate.pt (+1/-1)
lib/lp/translations/templates/translation-import-queue-macros.pt (+1/-1)
lib/lp/translations/templates/translationimportqueueentry-index.pt (+1/-1)
lib/lp/translations/templates/translationmessage-translate.pt (+1/-1)
Curtis Hovey (sinzui)
Changed in launchpad-registry:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Curtis Hovey (sinzui) wrote :

The app needs to explain the private teams cannot be members of other teams.

Curtis Hovey (sinzui)
tags: added: oops
Changed in launchpad-registry:
milestone: none → 3.1.11
Revision history for this message
Martin Pool (mbp) wrote :

The description of this seems to be incorrect: you get this message even if you do have access to the team, eg if I try to add ~canonical to ~contributor-agreement-canonical. Or is that a different bug?

Edwin Grubbs (edwin-grubbs)
Changed in launchpad-registry:
assignee: nobody → Edwin Grubbs (edwin-grubbs)
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Triaged → In Progress
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: 3.1.11 → 3.1.12
Revision history for this message
Karl Fogel (kfogel) wrote :

I second Martin's question from comment #2: when barry tried to add ~canonical to ~private-launchpad-strategy, he got this error as well.

See also bug #95193 ("Unhelpful error message adding team A as a member of team B when team B is already member of team A"), which has a similar symptom but a different cause.

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Yes, this bug has nothing to do with whether you have access to a team. Rather, it stems from the fact that the item exists in the vocabulary, thus preventing an "Invalid value" error, but the PublicPersonChoice.constraint() method returns false for non-public teams. I have changed the constraint() to raise a more informative exception.

Revision history for this message
Curtis Hovey (sinzui) wrote :

I am surprised that barry tried that, not to mention any launchpad developer tried that. Private teams cannot be members of other teams. The fix for the will land on edge in a few days. Since they cannot be members, I do not think bug #95193 is related in this case.

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Yes, this bug has nothing to do with whether you have access to a team. Rather, it stems from the fact that the item exists in the vocabulary, thus preventing an "Invalid value" error, but the PublicPersonChoice.constraint() method returns false for non-public teams. I have changed the constraint() to raise a more informative exception.

description: updated
Revision history for this message
Barry Warsaw (barry) wrote :

@Curtis: I knew there was a reason it failed, I just couldn't remember the error!

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote : Bug fixed by a commit

Fixed in devel r9989 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/revision/9989>

Changed in launchpad-registry:
status: In Progress → Fix Committed
Edwin Grubbs (edwin-grubbs)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.