The popup help system should not use an <iframe> defined as inline HTML.
Bug #295254 reported by
Māris Fogels
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
William Grant | ||
Bug Description
The popup help system shouldn't use inline HTML for it's <iframe>. Since the system only works if JavaScript is turned on, then the frame should be created dynamically.
Otherwise, we can/should remove the element altogether.
Also see https:/
Related branches
lp:~wgrant/launchpad/unhelp-pane
- William Grant: Approve (code)
-
Diff: 107 lines (+0/-81)3 files modifiedlib/canonical/launchpad/icing/css/components/help_pane.css (+0/-62)
lib/lp/app/browser/tests/test_base_layout.py (+0/-2)
lib/lp/app/templates/base-layout.pt (+0/-17)
| Changed in launchpad-foundations: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| tags: | added: tech-debt |
| affects: | launchpad-foundations → launchpad-web |
| Changed in launchpad-web: | |
| importance: | Medium → Low |
| tags: | added: javascript |
| Changed in launchpad: | |
| assignee: | nobody → William Grant (wgrant) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r17268 <http://