Merge proposal page truncates comments too soon

[Jamu Kakar]

The merge proposal page truncates review comments, showing a '(show
full message)' link to see the full message for each comment. It
only shows the first 3 lines of every comment, and I find myself
consistently doing a lot of clicking to read review threads.

I think truncation behaviour should be more like the bug page where
it's the exception, not the rule. Perhaps truncating at 40 lines
would be more appropriate? Alternately, an "expand all" button
might help, thought I'd prefer to not have to do anything to read
the review thread.

[Martin Albisetti (beuno)]

Yes, this would be good :)

[Martin Pool (mbp)]

Me too.

[James Westby (james-w)]

Hi,

A few lines in each comment would be bearable if it tried to do like the bugs
pages and collapse the quoted parts. Currently the 3 lines tend to be comment
attribution from mail clients, which is not very useful, if this was collapsed to one
line with an expand link then 3 lines or so of actual comment could be shown
before another expand link for the whole thing, making the collapsed view much
more useful.

Also, the fact that this is inconsistent with the bugs pages is not great in itself.
The comments are threaded, where the bugs ones aren't, but at least the display
could be the same; the difference seems gratuitous.

Thanks,

James

[Tim Penhey (thumper)]

Fixed in RF 7795.